Compare commits
20 Commits
cb14cf9bd4
...
v1.4
| Author | SHA1 | Date | |
|---|---|---|---|
| 1cb23a4411 | |||
| 479b592076 | |||
| 65cc8eaf8a | |||
| 4861179c6f | |||
| c9b37f2477 | |||
| d3799187a1 | |||
| b4eaa47ef6 | |||
| d6f334b861 | |||
| 8ab07b83ab | |||
| 95b83bd538 | |||
| ce53d3c1d2 | |||
| 16257f25d7 | |||
| c0ddb887ff | |||
| 22bd59a9d7 | |||
| d7f8618b38 | |||
| 5929585d6c | |||
| 187a9ead14 | |||
| 401d0e87a4 | |||
| fbacec7f6f | |||
| 553f006174 |
3
.gitignore
vendored
3
.gitignore
vendored
@@ -1,3 +1,4 @@
|
|||||||
.claude/*local*
|
.claude/*local*
|
||||||
|
dist/
|
||||||
|
.env
|
||||||
result
|
result
|
||||||
|
|||||||
77
CHANGELOG.md
77
CHANGELOG.md
@@ -1,5 +1,82 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## 1.4.0
|
||||||
|
|
||||||
|
### Breaking Changes
|
||||||
|
|
||||||
|
_None._
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
- **`schema_version` config field**: New optional integer field in `.josh-sync.yml`. Defaults to `1` when absent. josh-sync fails fast with a clear error if an unsupported version is present — safe path for future config migrations without silent misinterpretation.
|
||||||
|
|
||||||
|
### Fixes
|
||||||
|
|
||||||
|
- **Linearize fallback applying wrong diff**: Fallback for failed `cherry-pick` was diffing from `HEAD` to the commit's full tree instead of from the commit's own parent, causing unrelated file deletions. Now diffs from the commit's own parent (`${sha}^` / `${sha}^1`).
|
||||||
|
- **Linearize fallback for already-applied merge commits**: When `cherry-pick -m 1` produces an empty result because a merge's changes were already applied by a prior cherry-pick, the commit is now skipped instead of attempting a failing `git apply`.
|
||||||
|
- **Linearize fallback output**: Suppressed git noise from cherry-pick, checkout, and commit during linearization; added delimiters and consistent indented log lines.
|
||||||
|
|
||||||
|
### Docs
|
||||||
|
|
||||||
|
- Workflow guide: removed redundant step-by-step subsections (table already covers them); tightened ADR-011 alternatives; removed stale version pins.
|
||||||
|
- README: added Versioning section with semver policy table and floating tag explanation.
|
||||||
|
|
||||||
|
## 1.3.0
|
||||||
|
|
||||||
|
### Breaking Changes
|
||||||
|
|
||||||
|
_None._
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
- **Linearize fallback for reverse sync**: When josh-proxy rejects a push due to unmappable merge commits, reverse sync automatically falls back to linearizing the history — cherry-picking regular commits individually and squashing only the problematic merge commits via `cherry-pick -m 1`. Preserves individual commit granularity while handling complex merge topologies that josh cannot map. PR body notes when linearization was used.
|
||||||
|
|
||||||
|
### Fixes
|
||||||
|
|
||||||
|
- **Reverse sync human commit detection**: Fixed `--ancestry-path` returning empty when `mono-filtered` has advanced past the last forward sync. Any monorepo commit (even outside the subfolder) causes josh to create a new filtered commit, breaking the ancestry path to subrepo HEAD. Now uses `git merge-base` to find the last connected point.
|
||||||
|
- **State not updated on false skip**: When trees differ but no human commits are found, reverse sync now returns `skip-dirty` instead of `skip`. State is not updated, so the system retries on the next run instead of silently dropping commits.
|
||||||
|
|
||||||
|
### Docs
|
||||||
|
|
||||||
|
- Expanded troubleshooting guide for "Josh rejected push" with root cause analysis and prevention advice.
|
||||||
|
- Added ADR-011: Linearize fallback for reverse sync.
|
||||||
|
- Added recommended Git workflow section to the guide.
|
||||||
|
|
||||||
|
## 1.2.0
|
||||||
|
|
||||||
|
### Breaking Changes
|
||||||
|
|
||||||
|
_None._
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
- **File exclusion**: `exclude` config field removes files/directories from the subrepo at the josh-proxy transport layer. Patterns are embedded inline in the josh-proxy URL using `:exclude[::pattern,...]` syntax — no extra files to generate or commit.
|
||||||
|
- **Filter change reconciliation**: When the josh filter changes (e.g., adding/removing exclude patterns), josh-sync automatically creates a reconciliation merge commit that connects old and new histories. No manual reset or force-push required.
|
||||||
|
- **Tree comparison guard**: Reverse sync now compares subrepo tree to josh-filtered tree before checking commit log. Skips immediately when trees are identical, avoiding false positives from reconciliation merge history.
|
||||||
|
- **Unrelated histories detection**: Forward sync detects when histories are unrelated (no common ancestor) and falls back to reconciliation instead of creating a useless conflict PR.
|
||||||
|
|
||||||
|
### Fixes
|
||||||
|
|
||||||
|
- Pre-v1.2 state compatibility: When upgrading from v1.0/v1.1 (no `josh_filter` stored in state), the old filter is derived from `subfolder` so reconciliation triggers correctly.
|
||||||
|
- Reconciliation merge parent order: Josh-filtered history is always first parent so josh-proxy can follow first-parent traversal back to the monorepo.
|
||||||
|
- Reverse sync `--ancestry-path` flag prevents old subrepo history from leaking through reconciliation merge parents.
|
||||||
|
- PR body `\n` now renders as actual newlines instead of literal text.
|
||||||
|
- Conflict result no longer updates sync state (added `continue` to skip state write).
|
||||||
|
- `action.yml` now copies VERSION file for correct `--version` output in CI.
|
||||||
|
- `.gitignore` now includes `dist/` and `.env`.
|
||||||
|
|
||||||
|
## 1.1.0
|
||||||
|
|
||||||
|
### Breaking Changes
|
||||||
|
|
||||||
|
_None._
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
- **`onboard` command**: Interactive, resumable workflow for importing existing subrepos into the monorepo. Walks through: prerequisites check, import (creates PRs), wait for merge, reset (pushes josh-filtered history). Checkpoint/resume at every step.
|
||||||
|
- **`migrate-pr` command**: Migrates open PRs from an archived subrepo to the new one. Supports interactive selection, `--all` flag, and specific PR numbers. Uses `git apply --3way` for resilient patch application.
|
||||||
|
- **Onboard state tracking**: Stored on the `josh-sync-state` branch at `<target>/onboard.json`. Tracks step progress, import PR numbers, reset branches, and migrated PRs.
|
||||||
|
|
||||||
## 1.0.0
|
## 1.0.0
|
||||||
|
|
||||||
Initial release. Extracted from [private-monorepo-example](https://code.itkan.io/pe/private-monorepo-example) into a standalone reusable library.
|
Initial release. Extracted from [private-monorepo-example](https://code.itkan.io/pe/private-monorepo-example) into a standalone reusable library.
|
||||||
|
|||||||
26
README.md
26
README.md
@@ -16,12 +16,12 @@ josh:
|
|||||||
targets:
|
targets:
|
||||||
- name: "billing"
|
- name: "billing"
|
||||||
subfolder: "services/billing"
|
subfolder: "services/billing"
|
||||||
josh_filter: ":/services/billing"
|
|
||||||
subrepo_url: "git@gitea.example.com:ext/billing.git"
|
subrepo_url: "git@gitea.example.com:ext/billing.git"
|
||||||
subrepo_auth: "ssh"
|
subrepo_auth: "ssh"
|
||||||
branches:
|
branches:
|
||||||
main: main
|
main: main
|
||||||
forward_only: []
|
exclude: # files excluded from subrepo (optional)
|
||||||
|
- ".monorepo/"
|
||||||
|
|
||||||
bot:
|
bot:
|
||||||
name: "josh-sync-bot"
|
name: "josh-sync-bot"
|
||||||
@@ -58,8 +58,22 @@ Run `josh-sync preflight` to validate your setup.
|
|||||||
|
|
||||||
## Documentation
|
## Documentation
|
||||||
|
|
||||||
- **[Setup Guide](docs/guide.md)** — Step-by-step: prerequisites, importing existing subrepos, CI workflows, and troubleshooting
|
- **[Setup Guide](docs/guide.md)** — Step-by-step: prerequisites, importing existing subrepos, CI workflows, file exclusion, and troubleshooting
|
||||||
- **[Configuration Reference](docs/config-reference.md)** — Full `.josh-sync.yml` field documentation
|
- **[Configuration Reference](docs/config-reference.md)** — Full `.josh-sync.yml` field documentation
|
||||||
|
- **[Architecture Decision Records](docs/adr/)** — Design rationale and trade-offs
|
||||||
|
- **[Changelog](CHANGELOG.md)** — Version history
|
||||||
|
|
||||||
|
## Versioning
|
||||||
|
|
||||||
|
josh-sync follows [semver](https://semver.org/):
|
||||||
|
|
||||||
|
| Bump | Meaning | Action required |
|
||||||
|
|------|---------|-----------------|
|
||||||
|
| **Patch** (1.x.**y**) | Bug fixes only | Safe to upgrade |
|
||||||
|
| **Minor** (1.**y**.0) | New optional config fields, new commands, new action inputs | Safe to upgrade; new features are opt-in |
|
||||||
|
| **Major** (**y**.0.0) | Removed or renamed config fields, CLI flags, action inputs, env vars, or state format | Read the **Breaking Changes** section in the changelog before upgrading |
|
||||||
|
|
||||||
|
CI workflows pin to a floating major tag (e.g. `@v1`). A breaking change bumps the major version and moves the tag — `@v1` workflows keep working until you explicitly update to `@v2`.
|
||||||
|
|
||||||
## CLI
|
## CLI
|
||||||
|
|
||||||
@@ -79,12 +93,16 @@ josh-sync state reset <target> [branch]
|
|||||||
|
|
||||||
- **Forward sync** (mono → subrepo): pushes directly if clean, creates conflict PR if not. Uses `--force-with-lease` for safety.
|
- **Forward sync** (mono → subrepo): pushes directly if clean, creates conflict PR if not. Uses `--force-with-lease` for safety.
|
||||||
- **Reverse sync** (subrepo → mono): always creates a PR, never pushes directly.
|
- **Reverse sync** (subrepo → mono): always creates a PR, never pushes directly.
|
||||||
|
- **File exclusion**: `exclude` patterns are embedded inline in the josh-proxy URL. Excluded files exist only in the monorepo.
|
||||||
|
- **Filter reconciliation**: Changing the exclude list auto-creates a merge commit that connects old and new histories — no force-push needed.
|
||||||
- **Loop prevention**: `Josh-Sync-Origin:` git trailer filters out bot commits.
|
- **Loop prevention**: `Josh-Sync-Origin:` git trailer filters out bot commits.
|
||||||
- **State tracking**: orphan branch `josh-sync-state` stores JSON per target/branch.
|
- **State tracking**: orphan branch `josh-sync-state` stores JSON per target/branch.
|
||||||
|
|
||||||
## Dependencies
|
## Dependencies
|
||||||
|
|
||||||
`bash >=4`, `git`, `curl`, `jq`, `yq` ([mikefarah/yq](https://github.com/mikefarah/yq) v4+), `openssh`
|
`bash >=4`, `git`, `curl`, `jq`, `yq` ([mikefarah/yq](https://github.com/mikefarah/yq) v4+), `openssh`, `rsync`
|
||||||
|
|
||||||
|
> The Nix flake bundles all dependencies automatically.
|
||||||
|
|
||||||
## License
|
## License
|
||||||
|
|
||||||
|
|||||||
@@ -26,6 +26,7 @@ runs:
|
|||||||
run: |
|
run: |
|
||||||
JOSH_DIR="$(mktemp -d)"
|
JOSH_DIR="$(mktemp -d)"
|
||||||
cp -r "${{ github.action_path }}/bin" "${{ github.action_path }}/lib" "${JOSH_DIR}/"
|
cp -r "${{ github.action_path }}/bin" "${{ github.action_path }}/lib" "${JOSH_DIR}/"
|
||||||
|
cp "${{ github.action_path }}/VERSION" "${JOSH_DIR}/" 2>/dev/null || true
|
||||||
chmod +x "${JOSH_DIR}/bin/josh-sync"
|
chmod +x "${JOSH_DIR}/bin/josh-sync"
|
||||||
echo "${JOSH_DIR}/bin" >> "$GITHUB_PATH"
|
echo "${JOSH_DIR}/bin" >> "$GITHUB_PATH"
|
||||||
echo "JOSH_SYNC_ROOT=${JOSH_DIR}" >> "$GITHUB_ENV"
|
echo "JOSH_SYNC_ROOT=${JOSH_DIR}" >> "$GITHUB_ENV"
|
||||||
|
|||||||
@@ -208,13 +208,42 @@ _sync_direction() {
|
|||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
# Run sync
|
# Check for filter change (forward only — reverse uses same filter)
|
||||||
local result
|
local result
|
||||||
if [ "$direction" = "forward" ]; then
|
if [ "$direction" = "forward" ]; then
|
||||||
|
local prev_filter
|
||||||
|
prev_filter=$(echo "$state" | jq -r '.last_forward.josh_filter // empty')
|
||||||
|
|
||||||
|
# If no filter stored (pre-v1.2 state) but a previous sync exists,
|
||||||
|
# the old filter was the simple :/subfolder (before exclude was added)
|
||||||
|
if [ -z "$prev_filter" ]; then
|
||||||
|
local prev_mono_sha
|
||||||
|
prev_mono_sha=$(echo "$state" | jq -r '.last_forward.mono_sha // empty')
|
||||||
|
if [ -n "$prev_mono_sha" ]; then
|
||||||
|
local subfolder
|
||||||
|
subfolder=$(echo "$TARGET_JSON" | jq -r '.subfolder')
|
||||||
|
prev_filter=":/${subfolder}"
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
|
||||||
|
if [ -n "$prev_filter" ] && [ "$prev_filter" != "$JOSH_FILTER" ]; then
|
||||||
|
log "WARN" "Josh filter changed — reconciling histories"
|
||||||
|
log "INFO" "Old: ${prev_filter}"
|
||||||
|
log "INFO" "New: ${JOSH_FILTER}"
|
||||||
|
result=$(reconcile_filter_change)
|
||||||
|
else
|
||||||
result=$(forward_sync)
|
result=$(forward_sync)
|
||||||
|
fi
|
||||||
else
|
else
|
||||||
result=$(reverse_sync)
|
result=$(reverse_sync)
|
||||||
fi
|
fi
|
||||||
|
# If forward sync hit unrelated histories, fall back to reconciliation
|
||||||
|
if [ "$result" = "unrelated" ]; then
|
||||||
|
log "WARN" "Unrelated histories detected — falling back to filter reconciliation"
|
||||||
|
result=$(reconcile_filter_change)
|
||||||
|
log "INFO" "Reconciliation result: ${result}"
|
||||||
|
fi
|
||||||
|
|
||||||
log "INFO" "Result: ${result}"
|
log "INFO" "Result: ${result}"
|
||||||
|
|
||||||
# Handle warnings
|
# Handle warnings
|
||||||
@@ -224,11 +253,16 @@ _sync_direction() {
|
|||||||
fi
|
fi
|
||||||
if [ "$result" = "conflict" ]; then
|
if [ "$result" = "conflict" ]; then
|
||||||
echo "::warning::Target ${target_name}, branch ${branch}: merge conflict — PR created on subrepo"
|
echo "::warning::Target ${target_name}, branch ${branch}: merge conflict — PR created on subrepo"
|
||||||
|
continue
|
||||||
fi
|
fi
|
||||||
if [ "$result" = "josh-rejected" ]; then
|
if [ "$result" = "josh-rejected" ]; then
|
||||||
echo "::error::Target ${target_name}, branch ${branch}: josh rejected push — check proxy logs"
|
echo "::error::Target ${target_name}, branch ${branch}: josh rejected push — check proxy logs"
|
||||||
continue
|
continue
|
||||||
fi
|
fi
|
||||||
|
if [ "$result" = "skip-dirty" ]; then
|
||||||
|
log "WARN" "Trees differ but no human commits — skipping state update (will retry)"
|
||||||
|
continue
|
||||||
|
fi
|
||||||
|
|
||||||
# Update state (only on success)
|
# Update state (only on success)
|
||||||
local new_state
|
local new_state
|
||||||
@@ -240,8 +274,9 @@ _sync_direction() {
|
|||||||
--arg s_sha "${subrepo_sha_now:-}" \
|
--arg s_sha "${subrepo_sha_now:-}" \
|
||||||
--arg ts "$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
|
--arg ts "$(date -u +%Y-%m-%dT%H:%M:%SZ)" \
|
||||||
--arg status "$result" \
|
--arg status "$result" \
|
||||||
|
--arg filter "$JOSH_FILTER" \
|
||||||
--argjson prev "$state" \
|
--argjson prev "$state" \
|
||||||
'$prev + {last_forward: {mono_sha:$m_sha, subrepo_sha:$s_sha, timestamp:$ts, status:$status}}')
|
'$prev + {last_forward: {mono_sha:$m_sha, subrepo_sha:$s_sha, timestamp:$ts, status:$status, josh_filter:$filter}}')
|
||||||
else
|
else
|
||||||
local mono_sha_now
|
local mono_sha_now
|
||||||
mono_sha_now=$(git rev-parse "origin/${branch}" 2>/dev/null || echo "")
|
mono_sha_now=$(git rev-parse "origin/${branch}" 2>/dev/null || echo "")
|
||||||
@@ -735,6 +770,26 @@ cmd_migrate_pr() {
|
|||||||
|
|
||||||
log "INFO" "Archived repo: ${archived_api}"
|
log "INFO" "Archived repo: ${archived_api}"
|
||||||
|
|
||||||
|
# Load already-migrated PR numbers for skip detection and display
|
||||||
|
local migrated_numbers
|
||||||
|
migrated_numbers=$(echo "$onboard_state" | jq -r '[.migrated_prs // [] | .[].old_number] | map(tostring) | .[]')
|
||||||
|
|
||||||
|
# Counters for summary
|
||||||
|
local migrated=0 failed=0 skipped=0
|
||||||
|
|
||||||
|
# Helper: attempt migration of one PR with counting
|
||||||
|
_try_migrate() {
|
||||||
|
local num="$1"
|
||||||
|
if echo "$migrated_numbers" | grep -qx "$num"; then
|
||||||
|
log "INFO" "PR #${num} already migrated — skipping"
|
||||||
|
skipped=$((skipped + 1))
|
||||||
|
elif migrate_one_pr "$num"; then
|
||||||
|
migrated=$((migrated + 1))
|
||||||
|
else
|
||||||
|
failed=$((failed + 1))
|
||||||
|
fi
|
||||||
|
}
|
||||||
|
|
||||||
if [ "$all" = true ]; then
|
if [ "$all" = true ]; then
|
||||||
# Migrate all open PRs from archived repo
|
# Migrate all open PRs from archived repo
|
||||||
local prs
|
local prs
|
||||||
@@ -744,14 +799,14 @@ cmd_migrate_pr() {
|
|||||||
count=$(echo "$prs" | jq 'length')
|
count=$(echo "$prs" | jq 'length')
|
||||||
log "INFO" "Found ${count} open PR(s) on archived repo"
|
log "INFO" "Found ${count} open PR(s) on archived repo"
|
||||||
|
|
||||||
echo "$prs" | jq -r '.[] | .number' | while read -r num; do
|
while read -r num; do
|
||||||
migrate_one_pr "$num" || true
|
_try_migrate "$num"
|
||||||
done
|
done < <(echo "$prs" | jq -r '.[] | .number')
|
||||||
|
|
||||||
elif [ ${#pr_numbers[@]} -gt 0 ]; then
|
elif [ ${#pr_numbers[@]} -gt 0 ]; then
|
||||||
# Migrate specific PR numbers
|
# Migrate specific PR numbers
|
||||||
for num in "${pr_numbers[@]}"; do
|
for num in "${pr_numbers[@]}"; do
|
||||||
migrate_one_pr "$num" || true
|
_try_migrate "$num"
|
||||||
done
|
done
|
||||||
|
|
||||||
else
|
else
|
||||||
@@ -767,26 +822,33 @@ cmd_migrate_pr() {
|
|||||||
return
|
return
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
# Display PRs with [migrated] marker for already-processed ones
|
||||||
echo "" >&2
|
echo "" >&2
|
||||||
echo "Open PRs on archived repo:" >&2
|
echo "Open PRs on archived repo:" >&2
|
||||||
echo "$prs" | jq -r '.[] | " #\(.number): \(.title) (\(.base.ref) <- \(.head.ref))"' >&2
|
while IFS=$'\t' read -r num title base_ref head_ref; do
|
||||||
|
if echo "$migrated_numbers" | grep -qx "$num"; then
|
||||||
|
echo " #${num}: ${title} (${base_ref} <- ${head_ref}) [migrated]" >&2
|
||||||
|
else
|
||||||
|
echo " #${num}: ${title} (${base_ref} <- ${head_ref})" >&2
|
||||||
|
fi
|
||||||
|
done < <(echo "$prs" | jq -r '.[] | "\(.number)\t\(.title)\t\(.base.ref)\t\(.head.ref)"')
|
||||||
echo "" >&2
|
echo "" >&2
|
||||||
echo "Enter PR numbers to migrate (space-separated), or 'all':" >&2
|
echo "Enter PR numbers to migrate (space-separated), or 'all':" >&2
|
||||||
local selection
|
local selection
|
||||||
read -r selection
|
read -r selection
|
||||||
|
|
||||||
if [ "$selection" = "all" ]; then
|
if [ "$selection" = "all" ]; then
|
||||||
echo "$prs" | jq -r '.[] | .number' | while read -r num; do
|
while read -r num; do
|
||||||
migrate_one_pr "$num" || true
|
_try_migrate "$num"
|
||||||
done
|
done < <(echo "$prs" | jq -r '.[] | .number')
|
||||||
else
|
else
|
||||||
for num in $selection; do
|
for num in $selection; do
|
||||||
migrate_one_pr "$num" || true
|
_try_migrate "$num"
|
||||||
done
|
done
|
||||||
fi
|
fi
|
||||||
fi
|
fi
|
||||||
|
|
||||||
log "INFO" "PR migration complete"
|
log "INFO" "Migration complete: ${migrated} migrated, ${failed} failed, ${skipped} skipped"
|
||||||
}
|
}
|
||||||
|
|
||||||
# ─── Main ───────────────────────────────────────────────────────────
|
# ─── Main ───────────────────────────────────────────────────────────
|
||||||
|
|||||||
42
docs/adr/001-josh-proxy-for-sync.md
Normal file
42
docs/adr/001-josh-proxy-for-sync.md
Normal file
@@ -0,0 +1,42 @@
|
|||||||
|
# ADR-001: Josh-proxy for Bidirectional Sync
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-01
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
We need bidirectional sync between a monorepo and N external subrepos. Each subrepo corresponds to a subfolder in the monorepo. Developers on both sides should see a clean, complete git history — not synthetic commits or squashed blobs.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **git subtree**: Built into git. `git subtree split` extracts a subfolder into a standalone repo. However, subtree split rewrites history on every run (O(n) on total commits), creating new SHAs each time. Bidirectional sync requires manual `subtree merge` with conflict-prone history grafting. No transport-layer filtering — all content must be fetched.
|
||||||
|
|
||||||
|
2. **git submodule**: Tracks external repos via `.gitmodules` pointer commits. Does not provide content-level integration — monorepo commits don't contain subrepo files directly. Developers must run `git submodule update`. Bidirectional sync is not a supported workflow.
|
||||||
|
|
||||||
|
3. **Custom diff-and-patch scripts**: Compute diffs between monorepo subfolder and subrepo, apply patches in both directions. Fragile with renames, binary files, and merge conflicts. Loses authorship and commit granularity.
|
||||||
|
|
||||||
|
4. **josh-proxy**: A git proxy that computes filtered views of repositories in real-time. Clients `git clone` through josh and receive a repo containing only the specified subfolder, with history rewritten to match. Josh maintains a persistent SHA mapping, so the same monorepo commit always produces the same filtered SHA. Bidirectional: pushing back through josh maps filtered commits to monorepo commits.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Use josh-proxy as the transport layer for all sync operations.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Clean git history in both directions — no synthetic commits
|
||||||
|
- Deterministic SHA mapping — same monorepo state always produces same filtered SHA
|
||||||
|
- Bidirectional by design — push through josh maps back to monorepo
|
||||||
|
- Transport-layer filtering — content exclusion happens at clone/push time, not via generated files
|
||||||
|
- Supports any git hosting platform (Gitea, GitHub, GitLab) since it's a proxy
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Requires running a josh-proxy instance (operational overhead)
|
||||||
|
- Josh-proxy is a Rust project with a smaller community than git-native tools
|
||||||
|
- Proxy must have network access to the monorepo's git server
|
||||||
|
- Josh's SHA mapping is opaque — debugging requires understanding josh internals
|
||||||
|
- First-parent traversal behavior must be respected in merge commits (see ADR-008)
|
||||||
|
|
||||||
|
**Risks:**
|
||||||
|
- Josh-proxy downtime blocks all sync operations
|
||||||
|
- Josh-proxy bugs could corrupt history mapping (mitigated by force-with-lease on forward, always-PR on reverse)
|
||||||
50
docs/adr/002-state-on-orphan-branch.md
Normal file
50
docs/adr/002-state-on-orphan-branch.md
Normal file
@@ -0,0 +1,50 @@
|
|||||||
|
# ADR-002: State Storage on Orphan Git Branch
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-01
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Josh-sync needs persistent state to track what has already been synced (last-synced commit SHAs, timestamps, status). This prevents re-syncing unchanged content and enables incremental operation. The state must survive CI runner teardown — runners are ephemeral containers.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **File in the repo**: Commit a state JSON file to the monorepo. Every sync run creates a commit, polluting history. Race conditions when multiple sync jobs run concurrently.
|
||||||
|
|
||||||
|
2. **External database/KV store**: Redis, SQLite, or a cloud KV service. Adds an infrastructure dependency. Credentials and connectivity to manage.
|
||||||
|
|
||||||
|
3. **CI artifacts/cache**: Platform-specific (GitHub Actions cache, Gitea cache). Not portable across CI platforms. Expiry policies vary.
|
||||||
|
|
||||||
|
4. **Orphan git branch**: A branch with no parent relationship to the main history. Stores JSON files in a simple `<target>/<branch>.json` layout. Pushed to origin, so it survives runner teardown. No external dependencies — uses git itself.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Store sync state as JSON files on an orphan branch (`josh-sync-state`) in the monorepo.
|
||||||
|
|
||||||
|
### Storage layout
|
||||||
|
|
||||||
|
```
|
||||||
|
origin/josh-sync-state/
|
||||||
|
<target>/<branch>.json # sync state per target/branch
|
||||||
|
<target>/onboard.json # onboard workflow state (v1.1+)
|
||||||
|
```
|
||||||
|
|
||||||
|
### Implementation
|
||||||
|
|
||||||
|
- `read_state()`: `git fetch origin josh-sync-state && git show origin/josh-sync-state:<key>.json`
|
||||||
|
- `write_state()`: Uses `git worktree` to check out the orphan branch in a temp directory, writes JSON, commits, and pushes. This avoids touching the main working tree.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Zero external dependencies — only git
|
||||||
|
- Portable across CI platforms (Gitea Actions, GitHub Actions, local)
|
||||||
|
- Human-readable JSON files — easy to inspect and debug
|
||||||
|
- Atomic updates via git commit + push
|
||||||
|
- Natural namespacing via directory structure
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Concurrent writes can race (mitigated by concurrency groups in CI workflows)
|
||||||
|
- `git worktree` adds complexity to the write path
|
||||||
|
- State branch appears in `git branch -a` output (minor clutter)
|
||||||
|
- Push failures on the state branch are non-fatal (logged as warning, sync still succeeds)
|
||||||
33
docs/adr/003-force-with-lease-forward.md
Normal file
33
docs/adr/003-force-with-lease-forward.md
Normal file
@@ -0,0 +1,33 @@
|
|||||||
|
# ADR-003: Force-with-Lease for Forward Sync
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-01
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Forward sync pushes monorepo changes to the subrepo. If someone pushes directly to the subrepo between when josh-sync reads its HEAD and when josh-sync pushes, a naive `git push` would overwrite their work. A `git push --force` would be worse — it would silently destroy concurrent changes.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Use `git push --force-with-lease=refs/heads/<branch>:<expected-sha>` for all forward sync pushes. The expected SHA is recorded at the start of the sync operation (the "lease").
|
||||||
|
|
||||||
|
### How it works
|
||||||
|
|
||||||
|
1. Record subrepo HEAD SHA before any operations: `subrepo_sha=$(subrepo_ls_remote "$branch")`
|
||||||
|
2. Perform merge of monorepo changes onto subrepo state
|
||||||
|
3. Push with explicit lease: `--force-with-lease=refs/heads/main:<subrepo_sha>`
|
||||||
|
4. If the subrepo HEAD changed since step 1, git rejects the push
|
||||||
|
5. Josh-sync reports `lease-rejected` and retries on the next run
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Never overwrites concurrent changes — git atomically checks the expected SHA
|
||||||
|
- Explicit SHA lease (not just "current tracking ref") prevents stale-ref bugs
|
||||||
|
- Failed leases are retried on the next sync run — no data loss, just delay
|
||||||
|
- Works correctly with josh-proxy's SHA mapping
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Lease-rejected means the sync run did work that gets discarded (clone, merge, etc.)
|
||||||
|
- Persistent lease failures indicate a concurrent push pattern that needs investigation
|
||||||
|
- Requires the `--force-with-lease` flag with explicit SHA — the shorthand form (`--force-with-lease` without `=`) is unsafe because it uses the local tracking ref, which may be stale
|
||||||
41
docs/adr/004-always-pr-reverse.md
Normal file
41
docs/adr/004-always-pr-reverse.md
Normal file
@@ -0,0 +1,41 @@
|
|||||||
|
# ADR-004: Always-PR Policy for Reverse Sync
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-01
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Reverse sync brings subrepo changes back into the monorepo. The monorepo is the source of truth and typically has CI checks, code review requirements, and branch protection rules. Pushing directly to the monorepo's main branch would bypass these safeguards.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **Direct push**: Fast, but bypasses all review and CI. A bad subrepo commit could break the entire monorepo with no review gate.
|
||||||
|
|
||||||
|
2. **Always create a PR**: Pushes to a staging branch (`auto-sync/subrepo-<branch>-<timestamp>`), then creates a PR via API. Humans review and merge.
|
||||||
|
|
||||||
|
3. **Configurable per-target**: Let users choose direct push vs PR. Adds complexity and a dangerous default.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Reverse sync always creates a PR on the monorepo. Never pushes directly to the target branch.
|
||||||
|
|
||||||
|
### Implementation
|
||||||
|
|
||||||
|
1. Push subrepo HEAD through josh-proxy to a staging branch: `git push -o "base=main" josh://... HEAD:refs/heads/auto-sync/subrepo-main-<ts>`
|
||||||
|
2. Create PR via Gitea/GitHub API targeting the monorepo's main branch
|
||||||
|
3. PR includes a review checklist: scoped to subfolder, no leaked credentials, CI passes
|
||||||
|
|
||||||
|
The `-o "base=main"` option tells josh-proxy which monorepo branch to map the push against.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- All monorepo changes go through review — consistent with team workflow
|
||||||
|
- CI runs on the PR branch before merge
|
||||||
|
- Bad subrepo changes are caught before they affect the monorepo
|
||||||
|
- Audit trail via PR history
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Reverse sync is not instant — requires human action to merge the PR
|
||||||
|
- Stale PRs accumulate if subrepo changes frequently but PRs aren't merged promptly
|
||||||
|
- Adds API dependency (needs token with PR creation scope)
|
||||||
52
docs/adr/005-git-trailer-loop-prevention.md
Normal file
52
docs/adr/005-git-trailer-loop-prevention.md
Normal file
@@ -0,0 +1,52 @@
|
|||||||
|
# ADR-005: Git Trailer for Loop Prevention
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-01
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Bidirectional sync creates an infinite loop risk: forward sync pushes commit A to the subrepo, reverse sync sees commit A as "new" and creates a PR back to the monorepo, forward sync sees the merged PR as "new" and pushes again, etc.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **SHA tracking only**: Compare SHAs to skip already-synced content. Breaks when josh-proxy rewrites SHAs (which it always does for filtered views). The monorepo commit SHA and the filtered/subrepo commit SHA are never the same.
|
||||||
|
|
||||||
|
2. **Commit message prefix**: Add `[sync]` to bot commit messages. Fragile — humans might use the same prefix. Requires string matching on message content.
|
||||||
|
|
||||||
|
3. **Git trailer**: A structured key-value pair in the commit message body (after a blank line), following the `git interpret-trailers` convention. Format: `Key: value`. Machine-parseable, unlikely to be used by humans, and supported by `git log --grep`.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
All bot commits include a git trailer with a configurable key (default: `Josh-Sync-Origin`). Both sync directions filter out commits containing this trailer.
|
||||||
|
|
||||||
|
### Format
|
||||||
|
|
||||||
|
```
|
||||||
|
Sync from monorepo 2026-02-12T10:30:00Z
|
||||||
|
|
||||||
|
Josh-Sync-Origin: forward/main/2026-02-12T10:30:00Z
|
||||||
|
```
|
||||||
|
|
||||||
|
The trailer value encodes: direction, branch, and timestamp. This aids debugging but is not parsed by the loop filter — only the trailer key presence matters.
|
||||||
|
|
||||||
|
### Filtering
|
||||||
|
|
||||||
|
- **Reverse sync**: `git log --invert-grep --grep="^${BOT_TRAILER}:"` excludes all commits with the trailer
|
||||||
|
- **CI loop guard**: The composite action checks if HEAD commit has the trailer before running sync at all
|
||||||
|
|
||||||
|
### Configuration
|
||||||
|
|
||||||
|
The trailer key is set in `.josh-sync.yml` under `bot.trailer`. This allows multiple josh-sync instances (with different bots) to operate on the same repos without interfering.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Reliable loop prevention — trailer is part of the immutable commit object
|
||||||
|
- Configurable key avoids conflicts between multiple sync bots
|
||||||
|
- Human-readable — `git log` shows the trailer in commit messages
|
||||||
|
- CI loop guard prevents unnecessary sync runs entirely
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Commits with manually-added trailers matching the key would be incorrectly filtered
|
||||||
|
- Trailer must be in the commit body (after blank line), not the subject line
|
||||||
|
- Squash-and-merge on PRs may lose the trailer if the platform doesn't preserve commit message body
|
||||||
55
docs/adr/006-inline-exclude-filter.md
Normal file
55
docs/adr/006-inline-exclude-filter.md
Normal file
@@ -0,0 +1,55 @@
|
|||||||
|
# ADR-006: Inline Exclude in Josh-Proxy URL
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-02
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Some files in a monorepo subfolder should not appear in the subrepo (e.g., monorepo-specific CI configs, internal tooling, secrets templates). We need a mechanism to exclude these files from sync.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **`.josh-sync-exclude` file committed to the repo**: A gitignore-style file listing patterns. Requires generating and committing a file. Changes to the exclude list create commits. The file itself would need to be excluded from the subrepo (circular dependency).
|
||||||
|
|
||||||
|
2. **Post-clone file deletion**: Clone through josh, then `rm -rf` excluded paths before pushing. Fragile — deletions create diff noise. Doesn't work for reverse sync (excluded files would appear as "deleted" in the subrepo).
|
||||||
|
|
||||||
|
3. **Josh `:exclude` filter inline in the URL**: Josh-proxy supports `:exclude[::pattern1,::pattern2]` appended to the filter path. The exclusion happens at the transport layer — git objects for excluded files are never transferred. Works identically for clone (forward) and push (reverse).
|
||||||
|
|
||||||
|
4. **Separate josh filter file**: Generate a josh filter expression and store it somewhere. Adds state management complexity.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Embed exclusion patterns inline in the josh-proxy URL using josh's native `:exclude` syntax. The `exclude` config field in `.josh-sync.yml` is transformed at config parse time into the josh filter string.
|
||||||
|
|
||||||
|
### Example
|
||||||
|
|
||||||
|
Config:
|
||||||
|
```yaml
|
||||||
|
exclude:
|
||||||
|
- ".monorepo/"
|
||||||
|
- "**/internal/"
|
||||||
|
```
|
||||||
|
|
||||||
|
Produces josh filter:
|
||||||
|
```
|
||||||
|
:/services/billing:exclude[::.monorepo/,::**/internal/]
|
||||||
|
```
|
||||||
|
|
||||||
|
### Implementation
|
||||||
|
|
||||||
|
The `parse_config()` function in `lib/config.sh` uses jq to conditionally append `:exclude[...]` to the josh filter when the `exclude` array is non-empty. The enriched filter is stored in `JOSH_SYNC_TARGETS` JSON and used everywhere via `$JOSH_FILTER`.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Zero committed files — exclusion is purely in the URL
|
||||||
|
- Transport-layer filtering — excluded content never leaves the git server
|
||||||
|
- Works identically for forward sync (clone), reverse sync (push), and reset
|
||||||
|
- Tree comparison (`skip` detection) works correctly since excluded files aren't in the filtered view
|
||||||
|
- Standard josh syntax — no custom invention
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Josh's `:exclude` pattern syntax is limited (no negation, no regex — only glob-style patterns with `::` prefix)
|
||||||
|
- Long exclude lists make the URL unwieldy (though this is cosmetic — git handles long URLs fine)
|
||||||
|
- Changing the exclude list changes the josh filter, which changes all filtered SHAs (see ADR-007 for how this is handled)
|
||||||
|
- Debugging requires understanding josh's filter composition syntax
|
||||||
53
docs/adr/007-reconciliation-merge.md
Normal file
53
docs/adr/007-reconciliation-merge.md
Normal file
@@ -0,0 +1,53 @@
|
|||||||
|
# ADR-007: Reconciliation Merge for Filter Changes
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-02
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
When the josh filter changes (e.g., adding exclude patterns), josh-proxy recomputes the entire filtered history with new SHAs. The subrepo's existing history (based on the old filter) shares no common ancestor with the new filtered history. A naive forward sync would see "unrelated histories" and fail.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **Force-push to subrepo**: Replace subrepo history with the new filtered view (same as `josh-sync reset`). Destructive — all local clones become invalid, open PRs are orphaned, developers must re-clone.
|
||||||
|
|
||||||
|
2. **Cherry-pick new commits**: Identify commits that exist in the new filtered history but not the old, cherry-pick them onto the subrepo. Complex — the "same" commit has different SHAs in old vs new filtered history. No reliable way to match them.
|
||||||
|
|
||||||
|
3. **Reconciliation merge commit**: Create a merge commit on the subrepo that has both the new filtered HEAD and the old subrepo HEAD as parents, using the new filtered tree. This establishes shared ancestry without rewriting history.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
When josh-sync detects a filter change (stored filter in state differs from current `$JOSH_FILTER`), create a reconciliation merge commit using `git commit-tree`.
|
||||||
|
|
||||||
|
### How it works
|
||||||
|
|
||||||
|
1. Clone subrepo (has old history)
|
||||||
|
2. Fetch josh-proxy filtered view (has new history)
|
||||||
|
3. If trees are identical → skip (filter change had no effect on content)
|
||||||
|
4. Create merge commit: `git commit-tree <josh-tree> -p <josh-head> -p <subrepo-head>`
|
||||||
|
5. Push with `--force-with-lease`
|
||||||
|
|
||||||
|
The merge commit uses the josh-filtered tree (new content) and has two parents:
|
||||||
|
- **Parent 1**: josh-filtered HEAD (new filter history) — must be first (see ADR-008)
|
||||||
|
- **Parent 2**: subrepo HEAD (old filter history) — preserves old history as a side branch
|
||||||
|
|
||||||
|
### Detection
|
||||||
|
|
||||||
|
Filter change is detected by comparing the stored `josh_filter` in sync state with the current `$JOSH_FILTER`. For pre-v1.2 state (no filter stored), the old filter is derived as `:/<subfolder>`.
|
||||||
|
|
||||||
|
As a reactive fallback, `forward_sync()` also detects unrelated histories via `git merge-base` and falls back to reconciliation.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Non-destructive — old history is preserved as parent 2 of the merge
|
||||||
|
- Developers don't need to re-clone the subrepo
|
||||||
|
- Open PRs on the subrepo remain valid (they're based on commits that are still ancestors)
|
||||||
|
- Automatic — no manual intervention needed when changing exclude patterns
|
||||||
|
- Force-with-lease protects against concurrent changes during reconciliation
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- The merge commit is synthetic (created by bot, not a real merge of concurrent work)
|
||||||
|
- Parent ordering is critical — wrong order breaks josh's reverse mapping (see ADR-008)
|
||||||
|
- The reconciliation merge contains a bot trailer, so reverse sync correctly ignores it
|
||||||
|
- If the subrepo has diverged significantly (manual commits during filter change), the reconciliation merge may produce unexpected tree content (uses josh-filtered tree unconditionally)
|
||||||
42
docs/adr/008-first-parent-ordering.md
Normal file
42
docs/adr/008-first-parent-ordering.md
Normal file
@@ -0,0 +1,42 @@
|
|||||||
|
# ADR-008: First-Parent Ordering in Reconciliation Merges
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-02
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Josh-proxy uses **first-parent traversal** when mapping subrepo history back to the monorepo. When you push a commit through josh-proxy, josh walks the first-parent chain to find a commit it can map to a monorepo commit. If the first parent leads to unmappable history, josh cannot reconstruct the monorepo-side branch correctly.
|
||||||
|
|
||||||
|
This became critical when the reconciliation merge (ADR-007) initially had the wrong parent order: old subrepo history as parent 1, josh-filtered as parent 2. Josh followed parent 1, couldn't find any mappable commit, and created a monorepo branch containing only the subrepo subfolder content — effectively deleting 1280 files from the rest of the monorepo.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
In reconciliation merge commits, the josh-filtered HEAD **must be parent 1** (first parent). The old subrepo HEAD is parent 2.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git commit-tree "$josh_tree" \
|
||||||
|
-p "$josh_head" \ # parent 1: josh-filtered — josh follows this
|
||||||
|
-p "$subrepo_head" \ # parent 2: old history — side branch, ignored by josh
|
||||||
|
-m "..."
|
||||||
|
```
|
||||||
|
|
||||||
|
### Why this is safe
|
||||||
|
|
||||||
|
- The old subrepo HEAD (`subrepo_head`) is still an ancestor of the merge commit regardless of parent order — push succeeds either way
|
||||||
|
- `--ancestry-path` in reverse sync still follows `B → M → C` regardless of parent order (it traces all paths, not just first-parent)
|
||||||
|
- Josh follows first-parent and finds the josh-filtered commit, which maps cleanly back to the monorepo
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Josh can map the reconciliation merge back to the monorepo correctly
|
||||||
|
- Reverse sync through josh produces correct diffs (only subrepo-scoped changes)
|
||||||
|
- `git log --first-parent` on the subrepo shows the clean josh-filtered lineage
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- This is a subtle invariant — future changes to merge commit creation must preserve parent order
|
||||||
|
- The constraint is undocumented in josh-proxy's own documentation (discovered empirically)
|
||||||
|
- No automated test can verify this without a running josh-proxy instance
|
||||||
|
|
||||||
|
**Lesson learned:**
|
||||||
|
Parent order in `git commit-tree -p` is not cosmetic. For tools that rely on first-parent traversal (josh-proxy, `git log --first-parent`), parent 1 must be the "mainline" that the tool should follow.
|
||||||
53
docs/adr/009-tree-comparison-guard.md
Normal file
53
docs/adr/009-tree-comparison-guard.md
Normal file
@@ -0,0 +1,53 @@
|
|||||||
|
# ADR-009: Tree Comparison as Sync Skip Guard
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-02
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Both forward and reverse sync need to detect "nothing to do" quickly. The primary mechanism is SHA comparison against stored state (last-synced SHA). However, this misses cases where:
|
||||||
|
|
||||||
|
- State is reset or lost
|
||||||
|
- Reconciliation merges change SHAs without changing content
|
||||||
|
- Multiple sync runs overlap
|
||||||
|
|
||||||
|
Additionally, reverse sync originally relied on `git log <base>..HEAD` to find new commits. After a reconciliation merge, the `..` range can leak old subrepo history through the merge's second parent, creating false positives.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Add tree-level comparison as an early skip guard in both forward and reverse sync. Compare the git tree objects (which represent directory content, not commit history) to determine if there's actually any content difference.
|
||||||
|
|
||||||
|
### Forward sync
|
||||||
|
|
||||||
|
```bash
|
||||||
|
mono_tree=$(git rev-parse 'HEAD^{tree}')
|
||||||
|
subrepo_tree=$(git rev-parse "subrepo/${branch}^{tree}")
|
||||||
|
[ "$mono_tree" = "$subrepo_tree" ] && echo "skip"
|
||||||
|
```
|
||||||
|
|
||||||
|
### Reverse sync
|
||||||
|
|
||||||
|
```bash
|
||||||
|
subrepo_tree=$(git rev-parse "HEAD^{tree}")
|
||||||
|
josh_tree=$(git rev-parse "mono-filtered/${branch}^{tree}")
|
||||||
|
[ "$subrepo_tree" = "$josh_tree" ] && echo "skip"
|
||||||
|
```
|
||||||
|
|
||||||
|
Tree comparison happens **before** commit log analysis. If trees are identical, there is definitionally nothing to sync, regardless of what the commit history looks like.
|
||||||
|
|
||||||
|
### Combined with `--ancestry-path`
|
||||||
|
|
||||||
|
For reverse sync, even when trees differ, `git log --ancestry-path` restricts the commit range to the direct lineage between the two endpoints. This prevents old history from leaking through reconciliation merge parents.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Eliminates false positives from reconciliation merges (trees are identical after reconciliation)
|
||||||
|
- Fast — tree SHA comparison is O(1), no content traversal
|
||||||
|
- Correct by definition — if trees match, content is identical
|
||||||
|
- Defense in depth — works even when state tracking has gaps
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Tree comparison alone doesn't tell you *which* commits are new (still need `git log` for PR descriptions)
|
||||||
|
- Adds an extra `git rev-parse` call per sync direction (negligible cost)
|
||||||
|
- Cannot detect file-mode-only changes if josh normalizes modes (theoretical edge case)
|
||||||
76
docs/adr/010-onboard-checkpoint-resume.md
Normal file
76
docs/adr/010-onboard-checkpoint-resume.md
Normal file
@@ -0,0 +1,76 @@
|
|||||||
|
# ADR-010: Onboard Workflow with Checkpoint/Resume
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-02
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Onboarding an existing subrepo into the monorepo is a multi-step process that involves human interaction (renaming repos, merging PRs). The full flow is:
|
||||||
|
|
||||||
|
1. Prerequisites: rename existing repo, create new empty repo
|
||||||
|
2. Import: copy subrepo content into monorepo, create import PR(s)
|
||||||
|
3. Wait: human merges the import PR(s)
|
||||||
|
4. Reset: force-push josh-filtered history to the new empty repo
|
||||||
|
5. (Optional) Migrate open PRs from archived repo
|
||||||
|
|
||||||
|
Each step can fail or be interrupted. The process may span hours or days (waiting for PR review). If interrupted, restarting from scratch wastes work and can create duplicate PRs.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **Single-shot script**: Run all steps in sequence. If interrupted, must restart from scratch. Duplicate PRs if import step is re-run.
|
||||||
|
|
||||||
|
2. **Manual step-by-step commands**: `import`, then manually run `reset`. Simple but error-prone — users may forget steps or run them out of order.
|
||||||
|
|
||||||
|
3. **Checkpoint/resume with persistent state**: Track the current step and intermediate results (PR numbers, reset branches) in persistent state. On re-run, resume from the last completed step.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
Implement `josh-sync onboard` as a checkpoint/resume workflow with state stored on the `josh-sync-state` branch at `<target>/onboard.json`.
|
||||||
|
|
||||||
|
### State machine
|
||||||
|
|
||||||
|
```
|
||||||
|
start → importing → waiting-for-merge → resetting → complete
|
||||||
|
```
|
||||||
|
|
||||||
|
Each transition is persisted before proceeding. Re-running `josh-sync onboard <target>` reads the current step and resumes.
|
||||||
|
|
||||||
|
### State schema
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"step": "waiting-for-merge",
|
||||||
|
"archived_api": "https://host/api/v1/repos/org/repo-archived",
|
||||||
|
"archived_url": "git@host:org/repo-archived.git",
|
||||||
|
"archived_auth": "ssh",
|
||||||
|
"import_prs": { "main": 42 },
|
||||||
|
"reset_branches": ["main"],
|
||||||
|
"migrated_prs": [
|
||||||
|
{ "old_number": 5, "new_number": 12, "title": "Fix login" }
|
||||||
|
],
|
||||||
|
"timestamp": "2026-02-10T14:30:00Z"
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
### Per-branch progress
|
||||||
|
|
||||||
|
Import and reset both iterate over branches. Progress is saved after each branch, so interruption mid-iteration resumes at the next unprocessed branch.
|
||||||
|
|
||||||
|
### PR migration
|
||||||
|
|
||||||
|
`josh-sync migrate-pr` is a separate command that reads onboard state (for the archived repo URL) and tracks migrated PRs. It uses `git apply --3way` for resilient patch application — the subrepo's content is identical after reset, so patches apply cleanly.
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Safe to interrupt at any point — no duplicate work on resume
|
||||||
|
- Per-branch tracking prevents duplicate import PRs or redundant resets
|
||||||
|
- Archived repo URL stored in state — `migrate-pr` can operate independently
|
||||||
|
- `--restart` flag allows starting over if state is corrupted
|
||||||
|
- Human-friendly — prints instructions at each step
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- State management adds complexity (read/write onboard state, step validation)
|
||||||
|
- Interactive steps (`read -r`) are not suitable for fully automated pipelines
|
||||||
|
- Onboard state persists on the state branch even after completion (minor clutter)
|
||||||
|
- The step machine is linear — cannot skip steps or run them out of order
|
||||||
58
docs/adr/011-linearize-fallback-reverse.md
Normal file
58
docs/adr/011-linearize-fallback-reverse.md
Normal file
@@ -0,0 +1,58 @@
|
|||||||
|
# ADR-011: Linearize Fallback for Reverse Sync
|
||||||
|
|
||||||
|
**Status:** Accepted
|
||||||
|
**Date:** 2026-03
|
||||||
|
|
||||||
|
## Context
|
||||||
|
|
||||||
|
Josh-proxy rejects reverse sync pushes when the subrepo history contains merge commits whose parents it cannot map through the filter. This happens when:
|
||||||
|
|
||||||
|
1. A long-lived branch (e.g., `stage`) is merged into `main` via a merge commit
|
||||||
|
2. That branch contains auto-sync merge commits or criss-cross merges with `main`
|
||||||
|
3. Josh encounters the merge commit, tries to map both parents through the filter, and fails with a 500 error
|
||||||
|
|
||||||
|
This is a legitimate subrepo workflow — teams merge staging branches into main regularly. The sync tool should handle it without requiring teams to change their Git workflow.
|
||||||
|
|
||||||
|
### Alternatives considered
|
||||||
|
|
||||||
|
1. **Squash all commits into one**: Simple but destroys all commit granularity.
|
||||||
|
2. **Rewrite subrepo history**: Breaks josh's SHA mapping, forces all developers to re-clone.
|
||||||
|
3. **Linearize: cherry-pick regular commits, squash only merges**: Preserves individual commit granularity; only merge commits lose their multi-parent structure.
|
||||||
|
|
||||||
|
## Decision
|
||||||
|
|
||||||
|
When the direct push through josh-proxy fails, fall back to option 4: linearize the history by cherry-picking onto the josh-filtered base.
|
||||||
|
|
||||||
|
### How it works
|
||||||
|
|
||||||
|
1. Direct `git push` through josh-proxy is attempted first (existing behavior)
|
||||||
|
2. If it fails, create a temporary branch from `mono-filtered/<branch>`
|
||||||
|
3. Walk human commits (oldest-first, bot commits excluded) from the ancestry path:
|
||||||
|
- **Regular commits** (≤1 parent): `git cherry-pick <sha>` — preserves author, date, and message
|
||||||
|
- **Merge commits** (>1 parent): `git cherry-pick -m 1 <sha>` — applies the merge's diff relative to its first parent as a single commit
|
||||||
|
4. If cherry-pick conflicts (rare — usually due to ordering issues), fall back to `git diff | git apply` with the original author metadata
|
||||||
|
5. Push the linearized branch through josh-proxy
|
||||||
|
6. PR body includes a note explaining that merge commits were squashed
|
||||||
|
|
||||||
|
### What is preserved
|
||||||
|
|
||||||
|
- Individual non-merge commits (author, date, message, diff)
|
||||||
|
- The net effect of each merge commit (as a squashed single commit)
|
||||||
|
- The original commit list in the PR body for reference
|
||||||
|
|
||||||
|
### What is lost
|
||||||
|
|
||||||
|
- The multi-parent structure of merge commits (they become single-parent)
|
||||||
|
- The distinction between "changes introduced by the merge" vs "changes from each parent" — the merge is represented as its diff from first parent
|
||||||
|
|
||||||
|
## Consequences
|
||||||
|
|
||||||
|
**Positive:**
|
||||||
|
- Reverse sync no longer gets stuck on merge commits — handles the common case automatically
|
||||||
|
- Non-merge commits retain full granularity (no unnecessary squashing)
|
||||||
|
- Subrepo history is untouched — no rewriting, no broken sync relationship
|
||||||
|
- The PR body documents when linearization was used, so reviewers know
|
||||||
|
|
||||||
|
**Negative:**
|
||||||
|
- Merge commit semantics are lost on the monorepo side (they appear as regular commits)
|
||||||
|
- Adds complexity to the reverse sync path (two code paths: direct push and linearize fallback)
|
||||||
19
docs/adr/README.md
Normal file
19
docs/adr/README.md
Normal file
@@ -0,0 +1,19 @@
|
|||||||
|
# Architecture Decision Records
|
||||||
|
|
||||||
|
This directory contains Architecture Decision Records (ADRs) for josh-sync. Each ADR documents a significant design decision, its context, the alternatives considered, and the rationale for the chosen approach.
|
||||||
|
|
||||||
|
## Index
|
||||||
|
|
||||||
|
| ADR | Title | Status |
|
||||||
|
|-----|-------|--------|
|
||||||
|
| [001](001-josh-proxy-for-sync.md) | Josh-proxy for bidirectional sync | Accepted |
|
||||||
|
| [002](002-state-on-orphan-branch.md) | State storage on orphan git branch | Accepted |
|
||||||
|
| [003](003-force-with-lease-forward.md) | Force-with-lease for forward sync | Accepted |
|
||||||
|
| [004](004-always-pr-reverse.md) | Always-PR policy for reverse sync | Accepted |
|
||||||
|
| [005](005-git-trailer-loop-prevention.md) | Git trailer for loop prevention | Accepted |
|
||||||
|
| [006](006-inline-exclude-filter.md) | Inline exclude in josh-proxy URL | Accepted |
|
||||||
|
| [007](007-reconciliation-merge.md) | Reconciliation merge for filter changes | Accepted |
|
||||||
|
| [008](008-first-parent-ordering.md) | First-parent ordering in reconciliation merges | Accepted |
|
||||||
|
| [009](009-tree-comparison-guard.md) | Tree comparison as sync skip guard | Accepted |
|
||||||
|
| [010](010-onboard-checkpoint-resume.md) | Onboard workflow with checkpoint/resume | Accepted |
|
||||||
|
| [011](011-linearize-fallback-reverse.md) | Linearize fallback for reverse sync | Accepted |
|
||||||
@@ -32,6 +32,7 @@ Each target maps a monorepo subfolder to an external subrepo.
|
|||||||
| `subrepo_ssh_key_var` | string | No | `"SUBREPO_SSH_KEY"` | Name of the env var holding the SSH private key for this target. |
|
| `subrepo_ssh_key_var` | string | No | `"SUBREPO_SSH_KEY"` | Name of the env var holding the SSH private key for this target. |
|
||||||
| `branches` | object | Yes | — | Branch mapping: `mono_branch: subrepo_branch`. Each key-value pair syncs those branches bidirectionally. |
|
| `branches` | object | Yes | — | Branch mapping: `mono_branch: subrepo_branch`. Each key-value pair syncs those branches bidirectionally. |
|
||||||
| `forward_only` | string[] | No | `[]` | Branches that only sync mono → subrepo, never reverse. |
|
| `forward_only` | string[] | No | `[]` | Branches that only sync mono → subrepo, never reverse. |
|
||||||
|
| `exclude` | string[] | No | `[]` | File/directory patterns to exclude from sync via josh `:exclude` filter. Excluded files exist only in the monorepo, never in the subrepo. See [Excluding Files](guide.md#excluding-files-from-sync). |
|
||||||
|
|
||||||
## `bot` Section
|
## `bot` Section
|
||||||
|
|
||||||
|
|||||||
126
docs/guide.md
126
docs/guide.md
@@ -91,6 +91,9 @@ targets:
|
|||||||
branches:
|
branches:
|
||||||
main: main # mono_branch: subrepo_branch
|
main: main # mono_branch: subrepo_branch
|
||||||
forward_only: []
|
forward_only: []
|
||||||
|
exclude: # files excluded from subrepo (optional)
|
||||||
|
- ".monorepo/" # monorepo-only config dir
|
||||||
|
- "**/internal/" # internal dirs at any depth
|
||||||
|
|
||||||
- name: "auth"
|
- name: "auth"
|
||||||
subfolder: "services/auth"
|
subfolder: "services/auth"
|
||||||
@@ -183,7 +186,7 @@ To pin to a specific version, use a tag ref in `devenv.yaml`:
|
|||||||
|
|
||||||
```yaml
|
```yaml
|
||||||
josh-sync:
|
josh-sync:
|
||||||
url: git+https://your-gitea.example.com/org/josh-sync?ref=v1.1
|
url: git+https://your-gitea.example.com/org/josh-sync?ref=refs/tags/v1.2
|
||||||
flake: true
|
flake: true
|
||||||
```
|
```
|
||||||
|
|
||||||
@@ -515,6 +518,97 @@ Bot commits include a git trailer like `Josh-Sync-Origin: forward/main/2024-02-1
|
|||||||
|
|
||||||
Sync state is stored as JSON files on an orphan branch (`josh-sync-state`), one file per target/branch. This tracks the last-synced commit SHAs and timestamps to avoid re-syncing the same changes.
|
Sync state is stored as JSON files on an orphan branch (`josh-sync-state`), one file per target/branch. This tracks the last-synced commit SHAs and timestamps to avoid re-syncing the same changes.
|
||||||
|
|
||||||
|
## Recommended Git Workflow
|
||||||
|
|
||||||
|
Josh-proxy maps commits through a filter per-branch. It handles linear history and simple merges (short-lived feature branches) without issues. However, it **cannot map merge commits whose parents were created on the subrepo side** — because those commits were never pushed through josh and have no monorepo-side mapping.
|
||||||
|
|
||||||
|
This means cross-branch merges (e.g., `stage` → `main`) must happen on the monorepo side, where josh can filter the result cleanly.
|
||||||
|
|
||||||
|
### The rule
|
||||||
|
|
||||||
|
**The monorepo owns branch topology. The subrepo owns feature development.**
|
||||||
|
|
||||||
|
### What to do where
|
||||||
|
|
||||||
|
| Action | Where to do it | Why |
|
||||||
|
|--------|---------------|-----|
|
||||||
|
| Feature branch → `main` | **Subrepo** (PR, any merge strategy) | Short-lived branch with clean lineage — josh handles it |
|
||||||
|
| `stage` → `main` (promotion) | **Monorepo** | Cross-branch merge — forward sync propagates the result to both subrepo branches |
|
||||||
|
| `main` → `stage` (catch-up) | **Monorepo** | Same reason — avoids criss-cross merge history on subrepo |
|
||||||
|
| Hotfix to `main` | **Either side** | Single commit or small PR — works everywhere |
|
||||||
|
| Config/CI changes (monorepo-only) | **Monorepo** | Not synced to subrepo (use `exclude` for monorepo-only files) |
|
||||||
|
|
||||||
|
### What to avoid
|
||||||
|
|
||||||
|
- **Don't merge `stage` into `main` on the subrepo with a merge commit.** The merge parents include commits created on the subrepo side (forward sync merges, criss-cross merges) that josh has no mapping for. Josh rejects the push with a 500 error.
|
||||||
|
- **Don't merge `main` into `stage` on the subrepo.** Creates criss-cross merge history that causes the same josh mapping failure when `stage` is later merged back.
|
||||||
|
- **Don't rebase synced branches on the subrepo.** This rewrites commit SHAs that josh has already mapped, breaking the sync relationship.
|
||||||
|
|
||||||
|
### If you must merge cross-branch on the subrepo
|
||||||
|
|
||||||
|
Use a **squash merge**. A squash merge produces a single commit with one parent — josh can always map it. You lose the individual commit history on the target branch, but the sync goes through cleanly.
|
||||||
|
|
||||||
|
As a safety net, josh-sync automatically falls back to linearizing the history when josh rejects a push — cherry-picking regular commits individually and squashing only the problematic merge commits. See the [troubleshooting section](#josh-rejected-push-reverse-sync) and [ADR-011](adr/011-linearize-fallback-reverse.md).
|
||||||
|
|
||||||
|
## Excluding Files from Sync
|
||||||
|
|
||||||
|
Some files in the monorepo subfolder may not belong in the subrepo (e.g., monorepo-specific CI configs, internal tooling). The `exclude` config field removes these at the josh-proxy layer — excluded files never appear in the subrepo.
|
||||||
|
|
||||||
|
### Configuration
|
||||||
|
|
||||||
|
Add an `exclude` list to any target:
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
targets:
|
||||||
|
- name: "billing"
|
||||||
|
subfolder: "services/billing"
|
||||||
|
subrepo_url: "git@host:org/billing.git"
|
||||||
|
exclude:
|
||||||
|
- ".monorepo/" # directory at subfolder root
|
||||||
|
- "**/internal/" # directory at any depth
|
||||||
|
- "*.secret" # files by extension
|
||||||
|
branches:
|
||||||
|
main: main
|
||||||
|
```
|
||||||
|
|
||||||
|
### How it works
|
||||||
|
|
||||||
|
When `exclude` is present, josh-sync appends an inline `:exclude` filter to the josh-proxy URL. For the example above, the josh filter becomes:
|
||||||
|
|
||||||
|
```
|
||||||
|
:/services/billing:exclude[::.monorepo/,::**/internal/,::*.secret]
|
||||||
|
```
|
||||||
|
|
||||||
|
Josh-proxy applies this filter at the transport layer — no extra files to generate or commit. This means:
|
||||||
|
- **Forward sync**: the filtered clone already excludes the files
|
||||||
|
- **Reverse sync**: pushes through josh also respect the exclusion
|
||||||
|
- **Reset**: the subrepo history never contains excluded files
|
||||||
|
- **Tree comparison**: `skip` detection works correctly (excluded files are not in the diff)
|
||||||
|
|
||||||
|
### Pattern syntax
|
||||||
|
|
||||||
|
Josh uses `::` patterns inside `:exclude[...]`:
|
||||||
|
|
||||||
|
| Pattern | Matches |
|
||||||
|
|---------|---------|
|
||||||
|
| `dir/` | Directory at subfolder root |
|
||||||
|
| `file` | File at subfolder root |
|
||||||
|
| `**/dir/` | Directory at any depth |
|
||||||
|
| `**/file` | File at any depth |
|
||||||
|
| `*.ext` | Glob pattern (single `*` only) |
|
||||||
|
|
||||||
|
### Setup
|
||||||
|
|
||||||
|
1. Add `exclude` to the target in `.josh-sync.yml`
|
||||||
|
2. Run `josh-sync preflight` to verify the filter works
|
||||||
|
3. Forward sync will now exclude the specified files
|
||||||
|
|
||||||
|
No extra files to generate or commit — the exclusion is embedded directly in the josh-proxy URL.
|
||||||
|
|
||||||
|
### Changing the exclude list
|
||||||
|
|
||||||
|
You can safely add or remove patterns from `exclude` at any time. When josh-sync detects that the filter has changed since the last sync, it automatically creates a reconciliation merge commit on the subrepo that connects the old and new histories — no manual reset or force-push required. Developers do not need to re-clone the subrepo.
|
||||||
|
|
||||||
## Adding a New Target
|
## Adding a New Target
|
||||||
|
|
||||||
To add a new subrepo after initial setup:
|
To add a new subrepo after initial setup:
|
||||||
@@ -554,7 +648,35 @@ Normal: the subrepo changed while sync was running. The next sync run will pick
|
|||||||
|
|
||||||
### "Josh rejected push" (reverse sync)
|
### "Josh rejected push" (reverse sync)
|
||||||
|
|
||||||
Josh-proxy couldn't map the push back to the monorepo. Check josh-proxy logs, verify the josh filter is correct. May indicate a history divergence — consider running `josh-sync reset <target>`.
|
Josh-proxy couldn't map the push back to the monorepo. This has two common causes:
|
||||||
|
|
||||||
|
#### Merge commits with unmappable parents
|
||||||
|
|
||||||
|
**Symptom:** Josh returns `500 Internal Server Error` with a message like:
|
||||||
|
|
||||||
|
```
|
||||||
|
rejecting merge with 2 parents:
|
||||||
|
"Merge pull request 'stage' (#30) from stage into main" (c4fa3c9...)
|
||||||
|
1) "Merge branch 'auto-sync/import-...'" (4bf8704...)
|
||||||
|
2) "Merge branch 'main' into stage" (d021654...)
|
||||||
|
```
|
||||||
|
|
||||||
|
**Cause:** The subrepo has a merge commit whose parents josh-proxy cannot trace through its filter. This typically happens when:
|
||||||
|
- A long-lived branch (e.g., `stage`) is merged into `main` via a merge commit (not squash)
|
||||||
|
- That branch contains auto-sync merge commits or other history that doesn't exist in josh's filtered view
|
||||||
|
- Someone merges `main` into a feature/staging branch and then merges it back — the criss-cross parents confuse josh's mapping
|
||||||
|
|
||||||
|
**Automatic handling:** josh-sync automatically falls back to linearizing the history when the direct push fails. Regular commits are cherry-picked individually (preserving authorship and messages), while merge commits are squashed into single commits via `cherry-pick -m 1`. The PR notes when this fallback was used. See [ADR-011](adr/011-linearize-fallback-reverse.md).
|
||||||
|
|
||||||
|
**Prevention:** In josh-synced subrepos, prefer **squash merges** when merging long-lived branches (stage, develop) into the synced branch. Squash merges produce a single commit with no merge parents, which josh can always map. Regular feature branch merges (short-lived, no auto-sync history) are usually fine.
|
||||||
|
|
||||||
|
**Manual resolution (if automatic fallback also fails):** This indicates a more fundamental history issue. Options:
|
||||||
|
1. Cherry-pick the desired changes manually onto a clean branch and push through josh
|
||||||
|
2. Run `josh-sync reset <target>` to re-establish history (destructive — all subrepo clones must re-fetch)
|
||||||
|
|
||||||
|
#### Filter or path mismatch
|
||||||
|
|
||||||
|
Josh-proxy couldn't map the push due to an incorrect filter. Check josh-proxy logs, verify the `josh_filter` or `subfolder` in `.josh-sync.yml` is correct, and ensure the subfolder exists in the monorepo.
|
||||||
|
|
||||||
### Import PR shows "No changes"
|
### Import PR shows "No changes"
|
||||||
|
|
||||||
|
|||||||
@@ -5,12 +5,12 @@
|
|||||||
# In devenv.yaml:
|
# In devenv.yaml:
|
||||||
# inputs:
|
# inputs:
|
||||||
# josh-sync:
|
# josh-sync:
|
||||||
# url: github:org/josh-sync/v1.0.0
|
# url: git+https://your-gitea.example.com/org/josh-sync?ref=refs/tags/v1.2
|
||||||
# flake: true
|
# flake: true
|
||||||
#
|
#
|
||||||
# Or in flake.nix:
|
# Or in flake.nix:
|
||||||
# inputs.josh-sync = {
|
# inputs.josh-sync = {
|
||||||
# url = "github:org/josh-sync/v1.0.0";
|
# url = "git+https://your-gitea.example.com/org/josh-sync?ref=refs/tags/v1.2";
|
||||||
# inputs.nixpkgs.follows = "nixpkgs";
|
# inputs.nixpkgs.follows = "nixpkgs";
|
||||||
# };
|
# };
|
||||||
|
|
||||||
@@ -26,6 +26,8 @@
|
|||||||
# josh-sync preflight Validate config and connectivity
|
# josh-sync preflight Validate config and connectivity
|
||||||
# josh-sync import <target> Initial import from subrepo
|
# josh-sync import <target> Initial import from subrepo
|
||||||
# josh-sync reset <target> Reset subrepo to josh-filtered view
|
# josh-sync reset <target> Reset subrepo to josh-filtered view
|
||||||
|
# josh-sync onboard <target> Interactive import + reset workflow
|
||||||
|
# josh-sync migrate-pr <target> Migrate PRs from archived repo
|
||||||
# josh-sync status Show target config and sync state
|
# josh-sync status Show target config and sync state
|
||||||
# josh-sync state show <t> [b] Show state JSON
|
# josh-sync state show <t> [b] Show state JSON
|
||||||
# josh-sync state reset <t> [b] Reset state
|
# josh-sync state reset <t> [b] Reset state
|
||||||
|
|||||||
@@ -62,7 +62,7 @@ jobs:
|
|||||||
done | sort -u | paste -sd ',' -)
|
done | sort -u | paste -sd ',' -)
|
||||||
echo "targets=${TARGETS}" >> "$GITHUB_OUTPUT"
|
echo "targets=${TARGETS}" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
- uses: https://your-gitea.example.com/org/josh-sync@v1
|
- uses: https://your-gitea.example.com/org/josh-sync@v1.2
|
||||||
with:
|
with:
|
||||||
direction: forward
|
direction: forward
|
||||||
target: ${{ github.event.inputs.target || steps.detect.outputs.targets }}
|
target: ${{ github.event.inputs.target || steps.detect.outputs.targets }}
|
||||||
|
|||||||
@@ -10,17 +10,19 @@ josh:
|
|||||||
targets:
|
targets:
|
||||||
- name: "billing"
|
- name: "billing"
|
||||||
subfolder: "services/billing"
|
subfolder: "services/billing"
|
||||||
josh_filter: ":/services/billing"
|
# josh_filter auto-derived as ":/services/billing" if omitted
|
||||||
subrepo_url: "https://gitea.example.com/ext/billing.git"
|
subrepo_url: "https://gitea.example.com/ext/billing.git"
|
||||||
subrepo_auth: "https"
|
subrepo_auth: "https"
|
||||||
branches:
|
branches:
|
||||||
main: main
|
main: main
|
||||||
develop: develop
|
develop: develop
|
||||||
forward_only: []
|
forward_only: []
|
||||||
|
exclude: # files excluded from subrepo (optional)
|
||||||
|
- ".monorepo/" # directory at subfolder root
|
||||||
|
- "**/internal/" # directory at any depth
|
||||||
|
|
||||||
- name: "auth"
|
- name: "auth"
|
||||||
subfolder: "services/auth"
|
subfolder: "services/auth"
|
||||||
josh_filter: ":/services/auth"
|
|
||||||
subrepo_url: "git@gitea.example.com:ext/auth.git"
|
subrepo_url: "git@gitea.example.com:ext/auth.git"
|
||||||
subrepo_auth: "ssh"
|
subrepo_auth: "ssh"
|
||||||
# Per-target credential override (reads from $AUTH_SSH_KEY instead of $SUBREPO_SSH_KEY)
|
# Per-target credential override (reads from $AUTH_SSH_KEY instead of $SUBREPO_SSH_KEY)
|
||||||
@@ -31,7 +33,6 @@ targets:
|
|||||||
|
|
||||||
- name: "shared-lib"
|
- name: "shared-lib"
|
||||||
subfolder: "libs/shared"
|
subfolder: "libs/shared"
|
||||||
josh_filter: ":/libs/shared"
|
|
||||||
subrepo_url: "https://gitea.example.com/ext/shared-lib.git"
|
subrepo_url: "https://gitea.example.com/ext/shared-lib.git"
|
||||||
branches:
|
branches:
|
||||||
main: main
|
main: main
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ jobs:
|
|||||||
curl -sL "https://github.com/mikefarah/yq/releases/download/v4.44.6/yq_linux_amd64" \
|
curl -sL "https://github.com/mikefarah/yq/releases/download/v4.44.6/yq_linux_amd64" \
|
||||||
-o /usr/local/bin/yq && chmod +x /usr/local/bin/yq
|
-o /usr/local/bin/yq && chmod +x /usr/local/bin/yq
|
||||||
|
|
||||||
- uses: https://your-gitea.example.com/org/josh-sync@v1
|
- uses: https://your-gitea.example.com/org/josh-sync@v1.2
|
||||||
with:
|
with:
|
||||||
direction: reverse
|
direction: reverse
|
||||||
target: ${{ github.event.inputs.target || '' }}
|
target: ${{ github.event.inputs.target || '' }}
|
||||||
|
|||||||
@@ -16,6 +16,11 @@ parse_config() {
|
|||||||
local config_json
|
local config_json
|
||||||
config_json=$(yq -o json "$config_file") || die "Failed to parse ${config_file}"
|
config_json=$(yq -o json "$config_file") || die "Failed to parse ${config_file}"
|
||||||
|
|
||||||
|
# Schema version check (optional field — absent means v1)
|
||||||
|
local schema_version
|
||||||
|
schema_version=$(echo "$config_json" | jq -r '.schema_version // 1')
|
||||||
|
[ "$schema_version" = "1" ] || die "Unsupported schema_version ${schema_version} in ${config_file} (this version of josh-sync supports schema_version 1 — see CHANGELOG.md for migration instructions)"
|
||||||
|
|
||||||
# Export global values
|
# Export global values
|
||||||
export JOSH_PROXY_URL
|
export JOSH_PROXY_URL
|
||||||
JOSH_PROXY_URL=$(echo "$config_json" | jq -r '.josh.proxy_url')
|
JOSH_PROXY_URL=$(echo "$config_json" | jq -r '.josh.proxy_url')
|
||||||
@@ -36,7 +41,10 @@ parse_config() {
|
|||||||
export JOSH_SYNC_TARGETS
|
export JOSH_SYNC_TARGETS
|
||||||
JOSH_SYNC_TARGETS=$(echo "$config_json" | jq '[.targets[] | . +
|
JOSH_SYNC_TARGETS=$(echo "$config_json" | jq '[.targets[] | . +
|
||||||
# Auto-derive josh_filter from subfolder if not set
|
# Auto-derive josh_filter from subfolder if not set
|
||||||
(if (.josh_filter // "") == "" then
|
# When exclude patterns are present, append inline :exclude[::p1,::p2,...] to the filter
|
||||||
|
(if (.exclude // [] | length) > 0 then
|
||||||
|
{josh_filter: (":/" + .subfolder + ":exclude[" + (.exclude | map("::" + .) | join(",")) + "]")}
|
||||||
|
elif (.josh_filter // "") == "" then
|
||||||
{josh_filter: (":/" + .subfolder)}
|
{josh_filter: (":/" + .subfolder)}
|
||||||
else {} end) +
|
else {} end) +
|
||||||
# Derive gitea_host and subrepo_repo_path from subrepo_url
|
# Derive gitea_host and subrepo_repo_path from subrepo_url
|
||||||
|
|||||||
@@ -169,6 +169,17 @@ onboard_flow() {
|
|||||||
local import_prs
|
local import_prs
|
||||||
import_prs=$(echo "$onboard_state" | jq -r '.import_prs // {}')
|
import_prs=$(echo "$onboard_state" | jq -r '.import_prs // {}')
|
||||||
|
|
||||||
|
# Build the archived repo clone URL for initial_import().
|
||||||
|
# The content lives in the archived repo — the new repo at SUBREPO_URL is empty.
|
||||||
|
local archived_url archived_clone_url
|
||||||
|
archived_url=$(echo "$onboard_state" | jq -r '.archived_url')
|
||||||
|
if [ "${SUBREPO_AUTH:-https}" = "ssh" ]; then
|
||||||
|
archived_clone_url="$archived_url"
|
||||||
|
else
|
||||||
|
# shellcheck disable=SC2001
|
||||||
|
archived_clone_url=$(echo "$archived_url" | sed "s|https://|https://${BOT_USER}:${SUBREPO_TOKEN}@|")
|
||||||
|
fi
|
||||||
|
|
||||||
for branch in $branches; do
|
for branch in $branches; do
|
||||||
local mapped
|
local mapped
|
||||||
mapped=$(echo "$target_json" | jq -r --arg b "$branch" '.branches[$b] // empty')
|
mapped=$(echo "$target_json" | jq -r --arg b "$branch" '.branches[$b] // empty')
|
||||||
@@ -185,7 +196,7 @@ onboard_flow() {
|
|||||||
|
|
||||||
log "INFO" "Importing branch: ${branch} (subrepo: ${mapped})"
|
log "INFO" "Importing branch: ${branch} (subrepo: ${mapped})"
|
||||||
local result
|
local result
|
||||||
result=$(initial_import)
|
result=$(initial_import "$archived_clone_url")
|
||||||
log "INFO" "Import result for ${branch}: ${result}"
|
log "INFO" "Import result for ${branch}: ${result}"
|
||||||
|
|
||||||
if [ "$result" = "pr-created" ]; then
|
if [ "$result" = "pr-created" ]; then
|
||||||
@@ -325,7 +336,8 @@ onboard_flow() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
# ─── Migrate One PR ──────────────────────────────────────────────
|
# ─── Migrate One PR ──────────────────────────────────────────────
|
||||||
# Applies a PR's diff from the archived repo to the new subrepo.
|
# Fetches the PR's branch from the archived repo, computes a local diff,
|
||||||
|
# and applies it to the new subrepo with --3way for resilience.
|
||||||
# Usage: migrate_one_pr <pr_number>
|
# Usage: migrate_one_pr <pr_number>
|
||||||
#
|
#
|
||||||
# Expects: JOSH_SYNC_TARGET_NAME, SUBREPO_API, SUBREPO_TOKEN, BOT_NAME, BOT_EMAIL loaded
|
# Expects: JOSH_SYNC_TARGET_NAME, SUBREPO_API, SUBREPO_TOKEN, BOT_NAME, BOT_EMAIL loaded
|
||||||
@@ -365,15 +377,7 @@ migrate_one_pr() {
|
|||||||
|
|
||||||
log "INFO" "Migrating PR #${pr_number}: \"${title}\" (${base} <- ${head})"
|
log "INFO" "Migrating PR #${pr_number}: \"${title}\" (${base} <- ${head})"
|
||||||
|
|
||||||
# 2. Get diff from archived repo
|
# 2. Clone new subrepo, add archived repo as second remote
|
||||||
local diff
|
|
||||||
diff=$(get_pr_diff "$archived_api" "$archived_token" "$pr_number")
|
|
||||||
if [ -z "$diff" ]; then
|
|
||||||
log "WARN" "Empty diff for PR #${pr_number} — skipping"
|
|
||||||
return 1
|
|
||||||
fi
|
|
||||||
|
|
||||||
# 3. Clone new subrepo, apply patch
|
|
||||||
# Save cwd so we can restore it (function runs in caller's shell, not subshell)
|
# Save cwd so we can restore it (function runs in caller's shell, not subshell)
|
||||||
local original_dir
|
local original_dir
|
||||||
original_dir=$(pwd)
|
original_dir=$(pwd)
|
||||||
@@ -390,10 +394,32 @@ migrate_one_pr() {
|
|||||||
git config user.name "$BOT_NAME"
|
git config user.name "$BOT_NAME"
|
||||||
git config user.email "$BOT_EMAIL"
|
git config user.email "$BOT_EMAIL"
|
||||||
|
|
||||||
|
# Build authenticated URL for the archived repo
|
||||||
|
local archived_url archived_clone_url
|
||||||
|
archived_url=$(echo "$onboard_state" | jq -r '.archived_url')
|
||||||
|
if [ "${SUBREPO_AUTH:-https}" = "ssh" ]; then
|
||||||
|
archived_clone_url="$archived_url"
|
||||||
|
else
|
||||||
|
# shellcheck disable=SC2001
|
||||||
|
archived_clone_url=$(echo "$archived_url" | sed "s|https://|https://${BOT_USER}:${SUBREPO_TOKEN}@|")
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Fetch the PR's head and base branches from the archived repo
|
||||||
|
git remote add archived "$archived_clone_url"
|
||||||
|
git fetch archived "$head" "$base" 2>&1 \
|
||||||
|
|| die "Failed to fetch branches from archived repo"
|
||||||
|
|
||||||
|
# 3. Compute diff locally and apply with --3way
|
||||||
git checkout -B "$head" >&2
|
git checkout -B "$head" >&2
|
||||||
|
|
||||||
if echo "$diff" | git apply --check 2>/dev/null; then
|
local diff
|
||||||
echo "$diff" | git apply
|
diff=$(git diff "archived/${base}..archived/${head}")
|
||||||
|
if [ -z "$diff" ]; then
|
||||||
|
log "WARN" "Empty diff for PR #${pr_number} — skipping"
|
||||||
|
return 1
|
||||||
|
fi
|
||||||
|
|
||||||
|
if echo "$diff" | git apply --3way 2>&1; then
|
||||||
git add -A
|
git add -A
|
||||||
git commit -m "${title}
|
git commit -m "${title}
|
||||||
|
|
||||||
@@ -418,8 +444,8 @@ Migrated from archived repo PR #${pr_number}" >&2
|
|||||||
'.migrated_prs += [{"old_number":$old, "new_number":$new_num, "title":$title}]')
|
'.migrated_prs += [{"old_number":$old, "new_number":$new_num, "title":$title}]')
|
||||||
write_onboard_state "$target_name" "$onboard_state"
|
write_onboard_state "$target_name" "$onboard_state"
|
||||||
else
|
else
|
||||||
log "ERROR" "Patch doesn't apply cleanly for PR #${pr_number} — skipping"
|
log "ERROR" "Could not apply changes for PR #${pr_number} even with 3-way merge"
|
||||||
log "ERROR" "Manual migration needed: get diff from archived repo and resolve conflicts"
|
log "ERROR" "Manual migration needed: branch '${head}' from archived repo"
|
||||||
return 1
|
return 1
|
||||||
fi
|
fi
|
||||||
}
|
}
|
||||||
|
|||||||
285
lib/sync.sh
285
lib/sync.sh
@@ -11,7 +11,7 @@
|
|||||||
|
|
||||||
# ─── Forward Sync: Monorepo → Subrepo ──────────────────────────────
|
# ─── Forward Sync: Monorepo → Subrepo ──────────────────────────────
|
||||||
#
|
#
|
||||||
# Returns: fresh | skip | clean | lease-rejected | conflict
|
# Returns: fresh | skip | clean | lease-rejected | conflict | unrelated
|
||||||
|
|
||||||
forward_sync() {
|
forward_sync() {
|
||||||
local mono_branch="$SYNC_BRANCH_MONO"
|
local mono_branch="$SYNC_BRANCH_MONO"
|
||||||
@@ -97,7 +97,14 @@ ${BOT_TRAILER}: forward/${mono_branch}/$(date -u +%Y-%m-%dT%H:%M:%SZ)" >&2
|
|||||||
fi
|
fi
|
||||||
|
|
||||||
else
|
else
|
||||||
# Conflict!
|
# Check: unrelated histories (filter change) vs normal merge conflict
|
||||||
|
if ! git merge-base "subrepo/${subrepo_branch}" "$mono_head" >/dev/null 2>&1; then
|
||||||
|
log "INFO" "No common ancestor — histories are unrelated (filter change?)"
|
||||||
|
echo "unrelated"
|
||||||
|
return
|
||||||
|
fi
|
||||||
|
|
||||||
|
# Normal merge conflict
|
||||||
local conflicted
|
local conflicted
|
||||||
conflicted=$(git diff --name-only --diff-filter=U 2>/dev/null || echo "(unknown)")
|
conflicted=$(git diff --name-only --diff-filter=U 2>/dev/null || echo "(unknown)")
|
||||||
git merge --abort
|
git merge --abort
|
||||||
@@ -115,7 +122,14 @@ ${BOT_TRAILER}: forward/${mono_branch}/$(date -u +%Y-%m-%dT%H:%M:%SZ)" >&2
|
|||||||
local pr_body conflicted_list
|
local pr_body conflicted_list
|
||||||
# shellcheck disable=SC2001
|
# shellcheck disable=SC2001
|
||||||
conflicted_list=$(echo "$conflicted" | sed 's/^/- /')
|
conflicted_list=$(echo "$conflicted" | sed 's/^/- /')
|
||||||
pr_body="## Sync Conflict\n\nMonorepo \`${mono_branch}\` has changes that conflict with \`${subrepo_branch}\`.\n\n**Conflicted files:**\n${conflicted_list}\n\nPlease resolve and merge this PR to complete the sync."
|
pr_body="## Sync Conflict
|
||||||
|
|
||||||
|
Monorepo \`${mono_branch}\` has changes that conflict with \`${subrepo_branch}\`.
|
||||||
|
|
||||||
|
**Conflicted files:**
|
||||||
|
${conflicted_list}
|
||||||
|
|
||||||
|
Please resolve and merge this PR to complete the sync."
|
||||||
|
|
||||||
create_pr "${SUBREPO_API}" "${SUBREPO_TOKEN}" \
|
create_pr "${SUBREPO_API}" "${SUBREPO_TOKEN}" \
|
||||||
"$subrepo_branch" "$conflict_branch" \
|
"$subrepo_branch" "$conflict_branch" \
|
||||||
@@ -128,10 +142,93 @@ ${BOT_TRAILER}: forward/${mono_branch}/$(date -u +%Y-%m-%dT%H:%M:%SZ)" >&2
|
|||||||
fi
|
fi
|
||||||
}
|
}
|
||||||
|
|
||||||
|
# ─── Filter Change Reconciliation ─────────────────────────────────
|
||||||
|
# When the josh filter changes (e.g., exclude patterns added/removed),
|
||||||
|
# josh-proxy recomputes filtered history with new SHAs. This creates a
|
||||||
|
# merge commit on the subrepo that connects old and new histories,
|
||||||
|
# re-establishing shared ancestry without a destructive force-push.
|
||||||
|
# Returns: reconciled | lease-rejected
|
||||||
|
|
||||||
|
reconcile_filter_change() {
|
||||||
|
local mono_branch="$SYNC_BRANCH_MONO"
|
||||||
|
local subrepo_branch="$SYNC_BRANCH_SUBREPO"
|
||||||
|
local work_dir
|
||||||
|
work_dir=$(mktemp -d)
|
||||||
|
# shellcheck disable=SC2064 # Intentional early expansion — work_dir is local
|
||||||
|
trap "rm -rf '$work_dir'" EXIT
|
||||||
|
|
||||||
|
log "INFO" "=== Filter change reconciliation: ${mono_branch} ==="
|
||||||
|
|
||||||
|
# 1. Clone subrepo
|
||||||
|
git clone "$(subrepo_auth_url)" \
|
||||||
|
--branch "$subrepo_branch" --single-branch \
|
||||||
|
"${work_dir}/subrepo" || die "Failed to clone subrepo"
|
||||||
|
|
||||||
|
cd "${work_dir}/subrepo" || exit
|
||||||
|
git config user.name "$BOT_NAME"
|
||||||
|
git config user.email "$BOT_EMAIL"
|
||||||
|
|
||||||
|
local subrepo_head
|
||||||
|
subrepo_head=$(git rev-parse HEAD)
|
||||||
|
log "INFO" "Subrepo HEAD: ${subrepo_head:0:12}"
|
||||||
|
|
||||||
|
# 2. Fetch josh-proxy filtered view (new filter)
|
||||||
|
git remote add josh-filtered "$(josh_auth_url)"
|
||||||
|
git fetch josh-filtered "$mono_branch" || die "Failed to fetch from josh-proxy"
|
||||||
|
|
||||||
|
local josh_head josh_tree
|
||||||
|
josh_head=$(git rev-parse "josh-filtered/${mono_branch}")
|
||||||
|
# shellcheck disable=SC1083 # {tree} is git syntax, not shell brace expansion
|
||||||
|
josh_tree=$(git rev-parse "josh-filtered/${mono_branch}^{tree}")
|
||||||
|
log "INFO" "Josh-proxy HEAD (new filter): ${josh_head:0:12}"
|
||||||
|
|
||||||
|
# 3. Check if trees are already identical (filter change had no effect)
|
||||||
|
local subrepo_tree
|
||||||
|
# shellcheck disable=SC1083
|
||||||
|
subrepo_tree=$(git rev-parse "HEAD^{tree}")
|
||||||
|
if [ "$josh_tree" = "$subrepo_tree" ]; then
|
||||||
|
log "INFO" "Trees identical after filter change — no reconciliation needed"
|
||||||
|
echo "skip"
|
||||||
|
return
|
||||||
|
fi
|
||||||
|
|
||||||
|
# 4. Create merge commit: josh-proxy HEAD (first parent) + subrepo HEAD, with josh-proxy's tree
|
||||||
|
# Josh follows first-parent traversal — josh-filtered MUST be first so josh can map
|
||||||
|
# the history back to the monorepo. Old subrepo history hangs off parent 2.
|
||||||
|
local merge_commit
|
||||||
|
merge_commit=$(git commit-tree "$josh_tree" \
|
||||||
|
-p "$josh_head" \
|
||||||
|
-p "$subrepo_head" \
|
||||||
|
-m "Sync: filter configuration updated
|
||||||
|
|
||||||
|
${BOT_TRAILER}: filter-change/${mono_branch}/$(date -u +%Y-%m-%dT%H:%M:%SZ)")
|
||||||
|
|
||||||
|
git reset --hard "$merge_commit" >&2
|
||||||
|
log "INFO" "Created reconciliation merge: ${merge_commit:0:12}"
|
||||||
|
|
||||||
|
# 5. Record lease and push
|
||||||
|
local subrepo_sha
|
||||||
|
subrepo_sha=$(subrepo_ls_remote "$subrepo_branch")
|
||||||
|
|
||||||
|
if git push \
|
||||||
|
--force-with-lease="refs/heads/${subrepo_branch}:${subrepo_sha}" \
|
||||||
|
"$(subrepo_auth_url)" \
|
||||||
|
"HEAD:refs/heads/${subrepo_branch}"; then
|
||||||
|
|
||||||
|
log "INFO" "Filter change reconciled — shared ancestry re-established"
|
||||||
|
echo "reconciled"
|
||||||
|
else
|
||||||
|
log "WARN" "Force-with-lease rejected — subrepo changed during reconciliation"
|
||||||
|
echo "lease-rejected"
|
||||||
|
fi
|
||||||
|
}
|
||||||
|
|
||||||
# ─── Reverse Sync: Subrepo → Monorepo ──────────────────────────────
|
# ─── Reverse Sync: Subrepo → Monorepo ──────────────────────────────
|
||||||
#
|
#
|
||||||
# Always creates a PR on the monorepo — never pushes directly.
|
# Always creates a PR on the monorepo — never pushes directly.
|
||||||
# Returns: skip | pr-created | josh-rejected
|
# Returns: skip | skip-dirty | pr-created | josh-rejected
|
||||||
|
# skip — trees identical, nothing to do
|
||||||
|
# skip-dirty — trees differ but no human commits found (don't update state)
|
||||||
|
|
||||||
reverse_sync() {
|
reverse_sync() {
|
||||||
local mono_branch="$SYNC_BRANCH_MONO"
|
local mono_branch="$SYNC_BRANCH_MONO"
|
||||||
@@ -156,31 +253,174 @@ reverse_sync() {
|
|||||||
git remote add mono-filtered "$(josh_auth_url)"
|
git remote add mono-filtered "$(josh_auth_url)"
|
||||||
git fetch mono-filtered "$mono_branch" || die "Failed to fetch from josh-proxy"
|
git fetch mono-filtered "$mono_branch" || die "Failed to fetch from josh-proxy"
|
||||||
|
|
||||||
# 3. Find new human commits (excludes bot commits from forward sync)
|
# 3. Compare trees — skip if subrepo matches josh-filtered view
|
||||||
local human_commits
|
local subrepo_tree josh_tree
|
||||||
|
# shellcheck disable=SC1083 # {tree} is git syntax, not shell brace expansion
|
||||||
|
subrepo_tree=$(git rev-parse "HEAD^{tree}")
|
||||||
|
# shellcheck disable=SC1083
|
||||||
|
josh_tree=$(git rev-parse "mono-filtered/${mono_branch}^{tree}")
|
||||||
|
|
||||||
|
if [ "$subrepo_tree" = "$josh_tree" ]; then
|
||||||
|
log "INFO" "Subrepo tree matches josh-filtered view — nothing to sync"
|
||||||
|
echo "skip"
|
||||||
|
return
|
||||||
|
fi
|
||||||
|
|
||||||
|
# 4. Find new human commits (excludes bot commits from forward sync)
|
||||||
|
# Uses merge-base + --ancestry-path to restrict to the direct lineage.
|
||||||
|
# merge-base is needed because mono-filtered may have advanced past the
|
||||||
|
# last forward sync (any monorepo commit, even outside the subfolder,
|
||||||
|
# causes josh to create a new filtered commit). Using mono-filtered
|
||||||
|
# directly with --ancestry-path returns empty when it's not an ancestor
|
||||||
|
# of HEAD. merge-base always finds the last connected point.
|
||||||
|
local base human_commits
|
||||||
|
base=$(git merge-base "mono-filtered/${mono_branch}" HEAD 2>/dev/null || echo "")
|
||||||
|
|
||||||
|
if [ -n "$base" ]; then
|
||||||
|
human_commits=$(git log --ancestry-path "${base}..HEAD" \
|
||||||
|
--oneline --invert-grep --grep="^${BOT_TRAILER}:" 2>/dev/null || echo "")
|
||||||
|
else
|
||||||
|
# No common ancestor (first sync or fully diverged) — skip ancestry-path
|
||||||
human_commits=$(git log "mono-filtered/${mono_branch}..HEAD" \
|
human_commits=$(git log "mono-filtered/${mono_branch}..HEAD" \
|
||||||
--oneline --invert-grep --grep="^${BOT_TRAILER}:" 2>/dev/null || echo "")
|
--oneline --invert-grep --grep="^${BOT_TRAILER}:" 2>/dev/null || echo "")
|
||||||
|
fi
|
||||||
|
|
||||||
if [ -z "$human_commits" ]; then
|
if [ -z "$human_commits" ]; then
|
||||||
log "INFO" "No new human commits in subrepo — nothing to sync"
|
log "INFO" "No new human commits in subrepo — nothing to sync"
|
||||||
echo "skip"
|
echo "skip-dirty"
|
||||||
return
|
return
|
||||||
fi
|
fi
|
||||||
|
|
||||||
log "INFO" "New human commits to sync:"
|
log "INFO" "New human commits to sync:"
|
||||||
echo "$human_commits" >&2
|
echo "$human_commits" >&2
|
||||||
|
|
||||||
# 4. Push through josh to a staging branch
|
# 5. Push through josh to a staging branch
|
||||||
local ts
|
local ts
|
||||||
ts=$(date +%Y%m%d-%H%M%S)
|
ts=$(date +%Y%m%d-%H%M%S)
|
||||||
local staging_branch="auto-sync/subrepo-${subrepo_branch}-${ts}"
|
local staging_branch="auto-sync/subrepo-${subrepo_branch}-${ts}"
|
||||||
|
local push_ref="HEAD"
|
||||||
|
local linearized=false
|
||||||
|
|
||||||
if git push -o "base=${mono_branch}" "$(josh_auth_url)" "HEAD:refs/heads/${staging_branch}"; then
|
if ! git push -o "base=${mono_branch}" "$(josh_auth_url)" "${push_ref}:refs/heads/${staging_branch}" 2>/dev/null; then
|
||||||
log "INFO" "Pushed to staging branch via josh: ${staging_branch}"
|
# Josh rejects pushes when the history contains merge commits whose
|
||||||
|
# parents it cannot map (e.g., merges of staging/feature branches that
|
||||||
|
# include auto-sync history). Fall back to linearizing: cherry-pick
|
||||||
|
# regular commits as-is, squash only the problematic merge commits.
|
||||||
|
# See ADR-011.
|
||||||
|
log "WARN" "Direct push failed — linearizing history (cherry-pick + squash merges)"
|
||||||
|
log "INFO" "─── linearize start ───"
|
||||||
|
|
||||||
# 5. Create PR on monorepo (NEVER direct push)
|
local original_head
|
||||||
|
original_head=$(git rev-parse HEAD)
|
||||||
|
|
||||||
|
git checkout -b "tmp-linearize-$$" "mono-filtered/${mono_branch}" >/dev/null 2>&1 \
|
||||||
|
|| die "Failed to create linearize branch"
|
||||||
|
|
||||||
|
# Reuse merge-base from step 4 (same reasoning: mono-filtered may have
|
||||||
|
# advanced past the last forward sync, breaking --ancestry-path).
|
||||||
|
local commit_shas
|
||||||
|
if [ -n "$base" ]; then
|
||||||
|
commit_shas=$(git log --ancestry-path "${base}..${original_head}" \
|
||||||
|
--reverse --format="%H" --invert-grep --grep="^${BOT_TRAILER}:" 2>/dev/null || echo "")
|
||||||
|
else
|
||||||
|
commit_shas=$(git log "mono-filtered/${mono_branch}..${original_head}" \
|
||||||
|
--reverse --format="%H" --invert-grep --grep="^${BOT_TRAILER}:" 2>/dev/null || echo "")
|
||||||
|
fi
|
||||||
|
|
||||||
|
local sha
|
||||||
|
for sha in $commit_shas; do
|
||||||
|
local parent_count
|
||||||
|
parent_count=$(git cat-file -p "$sha" | grep -c "^parent ")
|
||||||
|
local short_msg
|
||||||
|
short_msg=$(git log -1 --format="%s" "$sha")
|
||||||
|
|
||||||
|
if [ "$parent_count" -le 1 ]; then
|
||||||
|
# Regular commit — cherry-pick to preserve message and authorship
|
||||||
|
if git cherry-pick "$sha" >/dev/null 2>&1; then
|
||||||
|
log "INFO" " cherry-pick ${sha:0:7}: ${short_msg}"
|
||||||
|
else
|
||||||
|
log "WARN" " conflict ${sha:0:7} — applying patch from parent"
|
||||||
|
git cherry-pick --abort 2>/dev/null
|
||||||
|
local msg author_name author_email author_date
|
||||||
|
msg=$(git log -1 --format="%B" "$sha")
|
||||||
|
author_name=$(git log -1 --format="%an" "$sha")
|
||||||
|
author_email=$(git log -1 --format="%ae" "$sha")
|
||||||
|
author_date=$(git log -1 --format="%aI" "$sha")
|
||||||
|
# Diff from the commit's own parent — NOT from HEAD (which is
|
||||||
|
# the linearize branch and may have a different base).
|
||||||
|
git diff "${sha}^" "$sha" | git apply --index >/dev/null 2>&1 \
|
||||||
|
|| die "Failed to apply diff for ${sha:0:7}"
|
||||||
|
GIT_AUTHOR_NAME="$author_name" GIT_AUTHOR_EMAIL="$author_email" \
|
||||||
|
GIT_AUTHOR_DATE="$author_date" \
|
||||||
|
git commit -m "$msg" >/dev/null 2>&1 || die "Failed to commit ${sha:0:7}"
|
||||||
|
log "INFO" " applied ${sha:0:7}: ${short_msg}"
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
# Merge commit — cherry-pick relative to first parent (squashes the merge)
|
||||||
|
local msg author_name author_email author_date
|
||||||
|
msg=$(git log -1 --format="%B" "$sha")
|
||||||
|
author_name=$(git log -1 --format="%an" "$sha")
|
||||||
|
author_email=$(git log -1 --format="%ae" "$sha")
|
||||||
|
author_date=$(git log -1 --format="%aI" "$sha")
|
||||||
|
|
||||||
|
if git cherry-pick -m 1 "$sha" >/dev/null 2>&1; then
|
||||||
|
log "INFO" " squash ${sha:0:7}: ${short_msg}"
|
||||||
|
else
|
||||||
|
# Cherry-pick failed — distinguish empty result (changes already
|
||||||
|
# applied by a prior cherry-pick) from a real conflict.
|
||||||
|
if git diff --cached --quiet 2>/dev/null && git diff --quiet 2>/dev/null; then
|
||||||
|
# Working tree clean — the merge changes are already present
|
||||||
|
git cherry-pick --abort 2>/dev/null || git reset --hard HEAD >/dev/null 2>&1
|
||||||
|
log "INFO" " skip ${sha:0:7}: ${short_msg} (already applied)"
|
||||||
|
else
|
||||||
|
# Real conflict — apply diff from first parent (what the merge
|
||||||
|
# actually introduced, NOT from HEAD which would capture all
|
||||||
|
# tree differences).
|
||||||
|
git cherry-pick --abort 2>/dev/null
|
||||||
|
git diff "${sha}^1" "$sha" | git apply --index >/dev/null 2>&1 \
|
||||||
|
|| die "Failed to apply merge diff for ${sha:0:7}"
|
||||||
|
GIT_AUTHOR_NAME="$author_name" GIT_AUTHOR_EMAIL="$author_email" \
|
||||||
|
GIT_AUTHOR_DATE="$author_date" \
|
||||||
|
git commit -m "$msg" >/dev/null 2>&1 || die "Failed to commit merge ${sha:0:7}"
|
||||||
|
log "INFO" " squash ${sha:0:7}: ${short_msg}"
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
log "INFO" "─── linearize done ────"
|
||||||
|
|
||||||
|
push_ref="HEAD"
|
||||||
|
linearized=true
|
||||||
|
|
||||||
|
git push -o "base=${mono_branch}" "$(josh_auth_url)" \
|
||||||
|
"${push_ref}:refs/heads/${staging_branch}" \
|
||||||
|
|| { log "ERROR" "Josh rejected linearized push — check josh-proxy logs"; echo "josh-rejected"; return; }
|
||||||
|
fi
|
||||||
|
|
||||||
|
log "INFO" "Pushed to staging branch via josh: ${staging_branch}${linearized:+ (linearized)}"
|
||||||
|
|
||||||
|
# 6. Create PR on monorepo (NEVER direct push)
|
||||||
local pr_body
|
local pr_body
|
||||||
pr_body="## Subrepo changes\n\nNew commits from subrepo \`${subrepo_branch}\`:\n\n\`\`\`\n${human_commits}\n\`\`\`\n\n**Review checklist:**\n- [ ] Changes scoped to synced subfolder\n- [ ] No leaked credentials or environment-specific config\n- [ ] CI passes"
|
local linearize_note=""
|
||||||
|
if [ "$linearized" = true ]; then
|
||||||
|
linearize_note="
|
||||||
|
> **Note:** Merge commits were squashed during sync because the subrepo
|
||||||
|
> history contained merges that josh-proxy cannot map (see ADR-011).
|
||||||
|
> Regular commits are preserved individually."
|
||||||
|
fi
|
||||||
|
pr_body="## Subrepo changes
|
||||||
|
|
||||||
|
New commits from subrepo \`${subrepo_branch}\`:
|
||||||
|
|
||||||
|
\`\`\`
|
||||||
|
${human_commits}
|
||||||
|
\`\`\`
|
||||||
|
${linearize_note}
|
||||||
|
**Review checklist:**
|
||||||
|
- [ ] Changes scoped to synced subfolder
|
||||||
|
- [ ] No leaked credentials or environment-specific config
|
||||||
|
- [ ] CI passes"
|
||||||
|
|
||||||
create_pr "${MONOREPO_API}" "${GITEA_TOKEN}" \
|
create_pr "${MONOREPO_API}" "${GITEA_TOKEN}" \
|
||||||
"$mono_branch" "$staging_branch" \
|
"$mono_branch" "$staging_branch" \
|
||||||
@@ -190,19 +430,19 @@ reverse_sync() {
|
|||||||
|
|
||||||
log "INFO" "Reverse sync PR created on monorepo"
|
log "INFO" "Reverse sync PR created on monorepo"
|
||||||
echo "pr-created"
|
echo "pr-created"
|
||||||
else
|
|
||||||
log "ERROR" "Josh rejected push — check josh-proxy logs"
|
|
||||||
echo "josh-rejected"
|
|
||||||
fi
|
|
||||||
}
|
}
|
||||||
|
|
||||||
# ─── Initial Import: Subrepo → Monorepo (first time) ───────────────
|
# ─── Initial Import: Subrepo → Monorepo (first time) ───────────────
|
||||||
#
|
#
|
||||||
# Used when a subrepo already has content and you're adding it to the
|
# Used when a subrepo already has content and you're adding it to the
|
||||||
# monorepo for the first time. Creates a PR.
|
# monorepo for the first time. Creates a PR.
|
||||||
|
# Usage: initial_import [clone_url_override]
|
||||||
|
# clone_url_override — if set, clone from this URL instead of subrepo_auth_url()
|
||||||
|
# (used by onboard to clone from the archived repo)
|
||||||
# Returns: skip | pr-created
|
# Returns: skip | pr-created
|
||||||
|
|
||||||
initial_import() {
|
initial_import() {
|
||||||
|
local clone_url="${1:-$(subrepo_auth_url)}"
|
||||||
local mono_branch="$SYNC_BRANCH_MONO"
|
local mono_branch="$SYNC_BRANCH_MONO"
|
||||||
local subrepo_branch="$SYNC_BRANCH_SUBREPO"
|
local subrepo_branch="$SYNC_BRANCH_SUBREPO"
|
||||||
local subfolder
|
local subfolder
|
||||||
@@ -225,8 +465,8 @@ initial_import() {
|
|||||||
--branch "$mono_branch" --single-branch \
|
--branch "$mono_branch" --single-branch \
|
||||||
"${work_dir}/monorepo" || die "Failed to clone monorepo"
|
"${work_dir}/monorepo" || die "Failed to clone monorepo"
|
||||||
|
|
||||||
# 2. Clone subrepo
|
# 2. Clone subrepo (or archived repo when clone_url is overridden)
|
||||||
git clone "$(subrepo_auth_url)" \
|
git clone "$clone_url" \
|
||||||
--branch "$subrepo_branch" --single-branch \
|
--branch "$subrepo_branch" --single-branch \
|
||||||
"${work_dir}/subrepo" || die "Failed to clone subrepo"
|
"${work_dir}/subrepo" || die "Failed to clone subrepo"
|
||||||
|
|
||||||
@@ -264,7 +504,14 @@ ${BOT_TRAILER}: import/${JOSH_SYNC_TARGET_NAME}/${ts}" >&2
|
|||||||
|
|
||||||
# 5. Create PR on monorepo
|
# 5. Create PR on monorepo
|
||||||
local pr_body
|
local pr_body
|
||||||
pr_body="## Initial import\n\nImporting existing subrepo \`${subrepo_branch}\` (${file_count} files) into \`${subfolder}/\`.\n\n**Review checklist:**\n- [ ] Content looks correct\n- [ ] No leaked credentials or environment-specific config\n- [ ] CI passes"
|
pr_body="## Initial import
|
||||||
|
|
||||||
|
Importing existing subrepo \`${subrepo_branch}\` (${file_count} files) into \`${subfolder}/\`.
|
||||||
|
|
||||||
|
**Review checklist:**
|
||||||
|
- [ ] Content looks correct
|
||||||
|
- [ ] No leaked credentials or environment-specific config
|
||||||
|
- [ ] CI passes"
|
||||||
|
|
||||||
create_pr "${MONOREPO_API}" "${GITEA_TOKEN}" \
|
create_pr "${MONOREPO_API}" "${GITEA_TOKEN}" \
|
||||||
"$mono_branch" "$staging_branch" \
|
"$mono_branch" "$staging_branch" \
|
||||||
|
|||||||
@@ -5,6 +5,11 @@
|
|||||||
"type": "object",
|
"type": "object",
|
||||||
"required": ["josh", "targets", "bot"],
|
"required": ["josh", "targets", "bot"],
|
||||||
"properties": {
|
"properties": {
|
||||||
|
"schema_version": {
|
||||||
|
"type": "integer",
|
||||||
|
"const": 1,
|
||||||
|
"description": "Schema version. Bump when config fields are removed or renamed (matches josh-sync major version)."
|
||||||
|
},
|
||||||
"josh": {
|
"josh": {
|
||||||
"type": "object",
|
"type": "object",
|
||||||
"required": ["proxy_url", "monorepo_path"],
|
"required": ["proxy_url", "monorepo_path"],
|
||||||
@@ -70,6 +75,12 @@
|
|||||||
"items": { "type": "string" },
|
"items": { "type": "string" },
|
||||||
"default": [],
|
"default": [],
|
||||||
"description": "Branches that only sync mono → subrepo (never reverse)"
|
"description": "Branches that only sync mono → subrepo (never reverse)"
|
||||||
|
},
|
||||||
|
"exclude": {
|
||||||
|
"type": "array",
|
||||||
|
"items": { "type": "string" },
|
||||||
|
"default": [],
|
||||||
|
"description": "File/directory patterns to exclude from sync via josh :exclude filter. Josh pattern syntax: 'dir/' for directories, '*.ext' for globs, '**/dir/' for nested matches. Patterns are embedded inline in the josh-proxy URL."
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user